On 21/05/13 17:09, Paolo Bonzini wrote:
>
>
> ----- Messaggio originale -----
>> Da: "Catalin Marinas" <[email protected]>
>> A: "Marc Zyngier" <[email protected]>
>> Cc: [email protected], [email protected],
>> [email protected], "Will Deacon"
>> <[email protected]>, [email protected], [email protected], "Christopher
>> Covington" <[email protected]>
>> Inviato: Martedì, 21 maggio 2013 17:42:27
>> Oggetto: Re: [PATCH v4 21/32] arm64: KVM: Build system integration
>>
>> On Tue, May 14, 2013 at 03:13:49PM +0100, Marc Zyngier wrote:
>>> --- /dev/null
>>> +++ b/arch/arm64/kvm/Kconfig
>> ...
>>> +config KVM_ARM_VGIC
>>> + bool
>>> + depends on KVM_ARM_HOST && OF
>>> + select HAVE_KVM_IRQCHIP
>>> + ---help---
>>> + Adds support for a hardware assisted, in-kernel GIC emulation.
>>> +
>>> +config KVM_ARM_TIMER
>>> + bool
>>> + depends on KVM_ARM_VGIC
>>> + select HAVE_KVM_IRQCHIP
>>> + ---help---
>>> + Adds support for the Architected Timers in virtual machines
>>> +
>>> +source drivers/virtio/Kconfig
>>
>> Shouldn't the above configs go to drivers/virtio/Kconfig as well (or
>> drivers/virtio/arm/Kconfig)?
>
> virtio doesn't mean "virtual versions of devices that also exist in
> hardware"; those are indeed in arch/ARCH/kvm. virtio is a specific bus
> for paravirtualized devices. It is not KVM-specific and the code runs
> in the guest (whereas arch/arm64/kvm/Kconfig is host code).
>
> That said, drivers/virtio/Kconfig is already sourced by drivers/Kconfig.
> Why do you need to source it again here?
Probably some brain fart on my side. I'll get rid of it.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
