On 21.03.2013, at 15:43, Scott Wood wrote:

> On 03/21/2013 03:28:35 AM, Alexander Graf wrote:
>> On 14.02.2013, at 06:49, Scott Wood wrote:
>> > Hook the MPIC code up to the KVM interfaces, add locking, etc.
>> >
>> > TODO: irqfd support
>> >
>> > Signed-off-by: Scott Wood <scottw...@freescale.com>
>> Could you please split this patch up on your next respin?
> 
> Any particular split you're looking for?

Anything that makes reviewing it easier :). I can't concentrate for 100k 
straight.

> The only reason it's split as much as it is already is to give some chance of 
> merging updates from QEMU being less painful.  As far as the kernel is 
> concerned, this is new code, which is not functional (and thus not built) 
> before this patch.  There aren't meaningful intermediate states.
> 
>> Also please make sure you don't have #if 0'ed code in here.
> 
> Well, yeah.  Note the RFC. :-)

Just wanted to make sure you don't forget them when you send out a non-RFC :). 
Not that I'd assume you'd do that ;)


Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to