On 08.10.2012, at 22:50, Scott Wood wrote: > On 10/07/2012 08:58:02 AM, Alexander Graf wrote: >> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S >> b/arch/powerpc/kvm/bookehv_interrupts.S >> index 099fe82..4421293 100644 >> --- a/arch/powerpc/kvm/bookehv_interrupts.S >> +++ b/arch/powerpc/kvm/bookehv_interrupts.S >> @@ -23,7 +23,6 @@ >> #include <asm/ppc_asm.h> >> #include <asm/kvm_asm.h> >> #include <asm/reg.h> >> -#include <asm/mmu-44x.h> >> #include <asm/page.h> >> #include <asm/asm-compat.h> >> #include <asm/asm-offsets.h> > > This could come out of here regardless of whether 44x stays.
:) > >> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c >> index 7d120dc..f522110 100644 >> --- a/arch/powerpc/kvm/powerpc.c >> +++ b/arch/powerpc/kvm/powerpc.c >> @@ -158,10 +158,7 @@ int kvmppc_kvm_pv(struct kvm_vcpu *vcpu) >> } >> case KVM_HCALL_TOKEN(KVM_HC_FEATURES): >> r = EV_SUCCESS; >> -#if defined(CONFIG_PPC_BOOK3S) || defined(CONFIG_KVM_E500V2) >> - /* XXX Missing magic page on 44x */ >> r2 |= (1 << KVM_FEATURE_MAGIC_PAGE); >> -#endif > > We also don't support this on e500mc -- or at least it hasn't been tested, > and would be pretty pointless nothing in the magic page traps on e500mc. Ah, good point! Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
