>-----Original Message----- >From: Herbert Xu [mailto:[email protected]] >Sent: Thursday, June 17, 2010 7:21 PM >To: Xin, Xiaohui >Cc: Stephen Hemminger; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; >[email protected] >Subject: Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from >external. > >On Sun, Jun 13, 2010 at 04:58:36PM +0800, Xin, Xiaohui wrote: >> >> Herbert, >> In this way, I think we should create 3 functions at least in drivers to >> allocate rx buffer, to >receive the rx buffers, and to clean the rx buffers. >> >> We can also have another way here. We can provide a function to only >> substitute >> alloc_page(), and a function to release the pages when cleaning the rx >> buffers. > >Yes that's exactly what I had in mind. > Herbert, I have questions about the idea above: 1) Since netdev_alloc_skb() is still there, and we only modify alloc_page(), then we don't need napi_gro_frags() any more, the driver's original receiving function is ok. Right?
2) Is napi_gro_frags() only suitable for TCP protocol packet? I have done a small test for ixgbe driver to let it only allocate paged buffers and found kernel hangs when napi_gro_frags() receives an ARP packet. 3) As I have mentioned above, with this idea, netdev_alloc_skb() will allocate as usual, the data pointed by skb->data will be copied into the first guest buffer. That means we should reserve sufficient room in guest buffer. For PS mode supported driver (for example ixgbe), the room will be more than 128. After 128bytes, we will put the first frag data. Look into virtio-net.c the function page_to_skb() and receive_mergeable(), that means we should modify guest virtio-net driver to compute the offset as the parameter for skb_set_frag(). How do you think about this? Attached is a patch to how to modify the guest driver. I reserve 512 bytes as an example, and transfer the header len of the skb in hdr->hdr_len. Thanks Xiaohui >Cheers, >-- >Visit Openswan at http://www.openswan.org/ >Email: Herbert Xu ~{PmV>HI~} <[email protected]> >Home Page: http://gondor.apana.org.au/~herbert/ >PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
mod-guest.diff
Description: mod-guest.diff
