On Mon, 2009-06-15 at 22:45 +0300, Michael Goldish wrote: > The following patches make some changes to step file tests: > * Rename parameter output_dir in barrier_2() to debug_dir. > * Move some code from run_steps() into barrier_2(). > * Add a new feature (keep_screendump_history) which allows the user to see > exactly what went wrong with a step file test. Currently only the last > screendump is kept for each failed step file test; with this feature > enabled, > all screendumps are kept in compact JPG format. > * Use the new feature by default in kvm_tests.cfg.sample. >
Other than minor comments, patch set looks good to me. Please let me know if you agree with my comments. -- Lucas Meneghel Rodrigues Software Engineer (QE) Red Hat - Emerging Technologies -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
