Jaswinder Singh Rajput wrote:
On Wed, 2009-05-27 at 12:05 +0200, Jan Kiszka wrote:
Jaswinder Singh Rajput wrote:
It will look more beautiful if we arrange MSR addresses in some order
(say increasing order) :

+#ifndef MSR_K8_SYSCFG
+#define MSR_K8_SYSCFG                   0xc0010010
+#endif
+
+#ifndef MSR_K7_HWCR
+#define MSR_K7_HWCR                     0xc0010015
+#endif
+
Well, I just used a different sorting key: K7 vs. K8...


sorting with K7, K8 are not very helpful, on the other hand if we sort
with MSR address it will be helpful in :
1. searching of MSR
2. adding new MSR
3. avoid duplicate MSR
4. of course looks beautiful ;-)

Let's not get carried away.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to