On 03/12/15 11:55, Pavel Fedin wrote:
> Hello!
>
>>> It's simply more convenient to use a pointer for exchange with
>>> userspace, see vgic_v3_cpu_regs_access() and callers. I wouldn't like
>>> to refactor the code again. What's your opinion on this?
>>
>> I still don't think this is a good idea. You can still store the value
>> as an integer in vgic_v3_cpu_regs_access(), and check the write property
>> to do the writeback on read. Which is the same thing I asked for in this
>> patch.
>
> Started doing this and found one more (big) reason against. All sysreg
> handlers have 'const struct sys_reg_params' declaration, and
> callers, and their callers... This 'const' is all around the code, and it
> would take a separate huge patch to un-const'ify all this.
> Does it worth that?
maz@approximate:~/Work/arm-platforms$ git diff --stat
arch/arm64/kvm/sys_regs.c | 36 ++++++++++++++++++------------------
arch/arm64/kvm/sys_regs.h | 2 +-
2 files changed, 19 insertions(+), 19 deletions(-)
Hardly a big deal... You can have that as a separate patch.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
