Hi Andre,
On Thu, Jun 19, 2014 at 01:44:37PM +0100, Andre Przywara wrote:
> Extend the vGIC handling code to deal with different IRQ chip devices
> instead of hard-coding the GICv2 in.
Minor comment, but there are a few stray pr_infos in here which I don't
think are especially useful.
> + if (!ioctl(gic_fd, KVM_HAS_DEVICE_ATTR, &offset_attr)) {
> + err = ioctl(gic_fd, KVM_GET_DEVICE_ATTR, &offset_attr);
> + if (err)
> + return err;
> + }
> +
> + cpu_if_addr += offset;
> +
> + err = ioctl(gic_fd, KVM_SET_DEVICE_ATTR, &cpu_if_attr);
> if (err)
> return err;
> + pr_info("creating GICv2 KVM device");
One here...
> + switch (type) {
> + case KVM_DEV_TYPE_ARM_VGIC_V2:
> + compatible = "arm,cortex-a15-gic";
> + pr_info("creating FDT for a GICv2");
... and here.
> diff --git a/tools/kvm/virtio/mmio.c b/tools/kvm/virtio/mmio.c
> index afae6a7..35dc113 100644
> --- a/tools/kvm/virtio/mmio.c
> +++ b/tools/kvm/virtio/mmio.c
> @@ -293,7 +293,7 @@ int virtio_mmio_init(struct kvm *kvm, void *dev, struct
> virtio_device *vdev,
> *
> * virtio_mmio.devices=0x200@0xd2000000:5,0x200@0xd2000200:6
> */
> - pr_info("virtio-mmio.devices=0x%x@0x%x:%d\n", VIRTIO_MMIO_IO_SIZE,
> vmmio->addr, line);
> + pr_info("virtio-mmio.devices=0x%x@0x%x:%d", VIRTIO_MMIO_IO_SIZE,
> vmmio->addr, line);
Huh?
Anyway, the general idea looks ok to me.
Will
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
