On Tue, Sep 30, 2008 at 01:10:28PM +0200, Ingo Molnar wrote:
>
> * Joerg Roedel <[EMAIL PROTECTED]> wrote:
>
> > +static int calgary_device_supported(struct device *dev)
> > +{
> > + struct iommu_table *tbl;
> > +
> > + tbl = find_iommu_table(dev);
> > +
> > + return translation_enabled(tbl);
> > +}
>
> i guess this could be written as a simple:
>
> > +static int calgary_device_supported(struct device *dev)
> > +{
> > + return translation_enabled(find_iommu_table(dev));
> > +}
Sure, but I prefer the explicit form since it lends itself to easier
debugging (oops line numbers, adding printks, etc.).
Cheers,
Muli
--
The First Workshop on I/O Virtualization (WIOV '08)
Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/
xxx
SYSTOR 2009---The Israeli Experimental Systems Conference
http://www.haifa.il.ibm.com/conferences/systor2009/
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
