----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/#review103767 -----------------------------------------------------------
Laurent, Pali, if I commit this as it is, then https://git.reviewboard.kde.org/r/130161/ (which ports all debugging statements to categorized logging) but splitting out https://github.com/paulolieuthier/kopete/commit/6a49f82775f3ebc164085874942a519d575b576e before, would it be acceptable? - Luigi Toscano On Giu. 10, 2017, 5 p.m., Paulo Lieuthier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130154/ > ----------------------------------------------------------- > > (Updated Giu. 10, 2017, 5 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > The history plugin port was not completed, so it is disabled. This patch > re-enables it, fixes it's building failures and fixes not saving the history > file when the directory doesn't exist. > > Pull from here: > https://github.com/paulolieuthier/kopete/commits/fix-history-plugin > > > Diffs > ----- > > libkopete/ui/kopeteview.h 070a3b8a2 > plugins/CMakeLists.txt 6216058ef > plugins/history/CMakeLists.txt ce90b84a3 > plugins/history/converter.cpp 3175beac1 > plugins/history/historyguiclient.cpp 41745bfe0 > plugins/history/historylogger.cpp 66b627030 > plugins/history/historyplugin.cpp 48cd98010 > plugins/history/historypreferences.cpp 9c64b4418 > > > Diff: https://git.reviewboard.kde.org/r/130154/diff/1/ > > > Testing > ------- > > Tested last messages appearance on reopening a chat window, using Jabber and > Test Protocol. > > > Thanks, > > Paulo Lieuthier > >
