Hi, Please review the following review requests from git.reviewboard whenever you make some time :) I have understood and discarded the useless autotests as they were not testing kopete related features. And will create updated ones on phabricator. Link - 1- https://git.reviewboard.kde.org/r/130195/ 2- https://git.reviewboard.kde.org/r/130225/ 3- https://git.reviewboard.kde.org/r/130183/ 4- https://git.reviewboard.kde.org/r/130173/ 5- https://git.reviewboard.kde.org/r/130155/
I have put the links for convenience as there were only five remaining. Regards, Vijay Krishnavanshi On 26 August 2017 at 18:47, laurent Montel <mon...@kde.org> wrote: > Hi > ok good idea. > Regards > Le samedi 26 août 2017, 15:08:53 CEST vijay krishnavanshi a écrit : > > Hi, > > > > As the git.reviewboard.kde.org is being phased out I will create all new > > review requests on phabricator.kde.org. > > > > Link to the Review Request I recently created: > > https://phabricator.kde.org/D7556 > > Please confirm that you got the email notification of it :) > > > > Link to repo on phabricator: https://phabricator.kde.org/source/kopete/ > > > > I will first fix the issues in git.reviewboard's review requests and will > > either submit them or discard. They will be available on > > git.reviewboard for reference later. > > > > Regards, > > Vijay Krishnavanshi > > > -- > Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer > KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 > 53, > www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent > software solutions > > >
