----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130164/#review103366 -----------------------------------------------------------
Basically I do not think we need to have XML storage in new KF5 Kopete. New storage (SQLite) should be enough. One storage would mean less (really less!) technical code around. What would be neeed is to convert old XML based history to new storage. - Pali Rohár On jún 24, 2017, 3:41 popoludní, Paulo Lieuthier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130164/ > ----------------------------------------------------------- > > (Updated jún 24, 2017, 3:41 popoludní) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > This is done on top of [1], I don't know how to upload a diff only for this > current branch. > > This patch sets the initial work to separate the history plugin interface > from its actual storage implementation details. I think isolating the XML > backend is a good idea, because it may continue to be used and it'll be > easier to test the new backend, comparing to the XML one. > > There are much more to do here, I will update the diff soon. > > Pull from here: > https://github.com/paulolieuthier/kopete/commits/initial-facade > > [1] https://git.reviewboard.kde.org/r/130154/ > > > Diffs > ----- > > libkopete/ui/kopeteview.h 070a3b8a227acadc21aab28bcc29223585c81862 > plugins/CMakeLists.txt 6216058ef93d1c4ae7860331b6e7ef0d8be8fce2 > plugins/history/CMakeLists.txt ce90b84a3b60a15db725c29cdb8b721545503ada > plugins/history/backends/historybackend.h PRE-CREATION > plugins/history/backends/historybackendfactory.h PRE-CREATION > plugins/history/backends/historybackendfactory.cpp PRE-CREATION > plugins/history/backends/xml/xmlhistorybackend.h PRE-CREATION > plugins/history/backends/xml/xmlhistorybackend.cpp PRE-CREATION > plugins/history/converter.cpp 3175beac164b673201dff785890bc4d8b1cc68df > plugins/history/historydialog.cpp c88ce515ec11844ea1c1c1c4451fdeeab2616439 > plugins/history/historyguiclient.cpp > 41745bfe090eeda437c4fca3072f9039b2af52a8 > plugins/history/historylogger.h ad60896108d5d02e390d09db49d121fdf2f8517b > plugins/history/historylogger.cpp 66b627030f9baf78d98c010c3cc2dc3e7cc08c99 > plugins/history/historyplugin.cpp 48cd98010c2f3e65ff76ce3b6e5a43c92e988478 > plugins/history/historypreferences.cpp > 9c64b44184923aa92fe9fb252bfc5dc4d868b908 > > Diff: https://git.reviewboard.kde.org/r/130164/diff/ > > > Testing > ------- > > > Thanks, > > Paulo Lieuthier > >
