----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129325/#review102822 -----------------------------------------------------------
protocols/jabber/libjingle/talk/session/phone/linphonemediaengine.cc (line 172) <https://git.reviewboard.kde.org/r/129325/#comment68456> It was told that passing NULL crash application. - Pali Rohár On nov. 3, 2016, 7:01 popoludní, Fabian Vogt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129325/ > ----------------------------------------------------------- > > (Updated nov. 3, 2016, 7:01 popoludní) > > > Review request for Kopete. > > > Repository: kopete > > > Description > ------- > > The API changed with mediastreamer 2.14, so introduce new global defines > to support both the new and the old API. > > > Diffs > ----- > > cmake/modules/FindMediastreamer.cmake 47fe5c3 > protocols/jabber/libjingle/CMakeLists.txt 7ea8c3e > protocols/jabber/libjingle/talk/session/phone/linphonemediaengine.cc > bd3de2b > > Diff: https://git.reviewboard.kde.org/r/129325/diff/ > > > Testing > ------- > > It builds. I'm not sure whether passing NULL as first parameter works, it > might just crash. > > > Thanks, > > Fabian Vogt > >
