> On máj 31, 2016, 9:47 dopoludnia, Pali Rohár wrote: > > Ship It! > > Pali Rohár wrote: > Just add proper BUG: and REVIEW: keywords into commit message > > Johannes Huber wrote: > I doubt that Peter has write access. I can do it for him. Which branch is > the target? Applications/16.04 and merge to master or just master? > > Pali Rohár wrote: > In this case I will take patch and commit it.
Done. It is bugfix, so correct is to push fix into Applications/* branch and then merge into master. - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128006/#review96073 ----------------------------------------------------------- On máj 31, 2016, 5:43 popoludní, Peter Levine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128006/ > ----------------------------------------------------------- > > (Updated máj 31, 2016, 5:43 popoludní) > > > Review request for Kopete and Luca Beltrame. > > > Bugs: 363053 > http://bugs.kde.org/show_bug.cgi?id=363053 > > > Repository: kopete > > > Description > ------- > > GCC-6 no longer supports using bool as a pointer constant. Use NULL instead. > > > Diffs > ----- > > plugins/history2/history2logger.h 13f159a2106a0fe6a265384f8762fe980ad65a77 > > Diff: https://git.reviewboard.kde.org/r/128006/diff/ > > > Testing > ------- > > Tested with gcc-6.1.0 and gcc-5.3.1-alpha20160301 on Gentoo Linux. > > Qt: 4.8.7 > KDE Development Platform: 4.14.20 > Kopete: 1.9.0 > > > Thanks, > > Peter Levine > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
