> On jan. 4, 2016, 1:22 popoludní, R.Harish  Navnit wrote:
> > protocols/groupwise/ui/gwprivacydialog.cpp, line 278
> > <https://git.reviewboard.kde.org/r/124181/diff/6-7/?file=400129#file400129line278>
> >
> >     There's an obvious typo here, which I've fixed locally, but for some 
> > reason reviewboard doesn't pick it up. Here's the actual diff : 
> > http://ix.io/n9n

Rebase patch on top of origin/master where origin is 
git://anongit.kde.org/kopete and upload that one patch again. It should work.


- Pali


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124181/#review90538
-----------------------------------------------------------


On jan. 4, 2016, 1:20 popoludní, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124181/
> -----------------------------------------------------------
> 
> (Updated jan. 4, 2016, 1:20 popoludní)
> 
> 
> Review request for Kopete and Laurent Montel.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> Remove the K3ListBox and needless includes from groupwise.
> 
> 
> Diffs
> -----
> 
>   protocols/groupwise/gwconnector.cpp 
> d1330ad824dc7c731dc37a95b8735273c4890a46 
>   protocols/groupwise/ui/gwchatprops.ui 
> f93fb5db8269323d5b28bd60181bbe3a209f80e3 
>   protocols/groupwise/ui/gwchatpropsdialog.cpp 
> 5226bb3959439e0c954c7416c10ce839988f8d2e 
>   protocols/groupwise/ui/gwprivacy.ui 
> 34fc4e41a669994d90e0fd2de218367d4e2917ea 
>   protocols/groupwise/ui/gwprivacydialog.h 
> 595a031de6383ea27e9b2d54e270044b4e715cf2 
>   protocols/groupwise/ui/gwprivacydialog.cpp 
> 3b2210f6907d29931de50e27f299fa67b6c7fdc6 
> 
> Diff: https://git.reviewboard.kde.org/r/124181/diff/
> 
> 
> Testing
> -------
> 
> Build succeeds.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to