> On júl 25, 2015, 3:13 popoludní, Pali Rohár wrote: > > plugins/texteffect/texteffectpreferences.cpp, line 160 > > <https://git.reviewboard.kde.org/r/124094/diff/6-7/?file=384109#file384109line160> > > > > Are you sure that -1 is working? I did not find anything in > > documentation about it... > > R.Harish Navnit wrote: > Neither did I. But it in exactly the same way as it was working before. > Remove, MoveUp, MoveDown - all work fine. Any color that's added is added to > the end of the list.
Now I looked at http://doc.qt.io/qt-4.8/qlistwidget.html documentation again. And there is function: void QListWidget::addItem(const QString & label) Inserts an item with the text label at the end of the list widget. Why not to use it instead? - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review82931 ----------------------------------------------------------- On júl 25, 2015, 2:40 popoludní, R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124094/ > ----------------------------------------------------------- > > (Updated júl 25, 2015, 2:40 popoludní) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Replace the K3ListBox classes with QListWidget. > > > Diffs > ----- > > plugins/texteffect/texteffectpreferences.cpp > 35fac60d419cbac5644a8e143be1fc7c640385a9 > plugins/texteffect/texteffectprefs.ui > 1b82f3de4b449373a3dedb39b664c0f645f1d02a > > Diff: https://git.reviewboard.kde.org/r/124094/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
