> On June 26, 2015, 10:26 a.m., Laurent Montel wrote: > > protocols/meanwhile/CMakeLists.txt, line 4 > > <https://git.reviewboard.kde.org/r/124184/diff/1/?file=381418#file381418line4> > > > > Why this definition ? > > R.Harish Navnit wrote: > It was suggested by Pali on the mailing list. It enables warnings for all > deprecated functions and all qt3/kde3 functions, so that we get an idea of > everything that needs to be ported to KDE4 at compile time. > > Pali Rohár wrote: > It was suggestion for you when porting code :-) not something which > should be in Kopete tree enabled by default.
Oh yes. It does make sense :P I'll update it. - R.Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124184/#review81762 ----------------------------------------------------------- On June 26, 2015, 9:58 a.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124184/ > ----------------------------------------------------------- > > (Updated June 26, 2015, 9:58 a.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Replace the Q3GroupBox widgets with QGroupBox instead. > > > Diffs > ----- > > protocols/meanwhile/CMakeLists.txt 5b3e7d468bda985add7a83c1b3f9a9939c8ef81f > protocols/meanwhile/ui/meanwhileeditaccount.ui > 5e61aed483fb2501a26aa2452247e0a61782ed8d > > Diff: https://git.reviewboard.kde.org/r/124184/diff/ > > > Testing > ------- > > Build succeeded. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
