> On jún 23, 2015, 9:41 dopoludnia, R.Harish Navnit wrote: > > This change has been pushed to the frameworks scratch repo : > > http://quickgit.kde.org/?p=clones%2Fkopete%2Frharishnavnit%2Fframeworks.git&a=commit&h=1b3909d2d81042804a217bfe9f81b8caa38bdb86 > > > > > > Should this be closed/marked as submitted now ? > > Laurent Montel wrote: > As Pali Rohar told you in comment "Patch is OK. Now try to setup your own > personal cloned git repository and commit this patch into it (do not remember > "REVIEW: 123489" keywoard in commit message)." > you forgot to add REVIEW:.... > > Pali Rohár wrote: > If you have some commits ready for merging into kopete master, please > create new branch in your clonned repository and add that commits into that > branch. Then ping back and we can merge your branch into kopete master. Until > now you did not send any information what you want to merge... > > R.Harish Navnit wrote: > I was thinking of creating a new branch and adding commits as soon as > kde3 dependencies are completely removed. Just the kopete/protocols remain > now in this respect, I thought it would be better to wait. No ?
If you do not tell me location of git repository and branch (which contains your commits) I cannot merge them into kopete -- because I do not know what to merge. This one review request is OK and can be merged into kopete master. - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123489/#review81695 ----------------------------------------------------------- On máj 9, 2015, 8:58 dopoludnia, R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123489/ > ----------------------------------------------------------- > > (Updated máj 9, 2015, 8:58 dopoludnia) > > > Review request for Kopete and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > The following k3listview includes do not affect complilation and/or run of > the kopete application. > > > Diffs > ----- > > kopete/addaccountwizard/addaccountwizard.cpp > cc9fc8a5a4960e6a1eb00100bca1aab4952e8ed2 > kopete/contactlist/kopetestatusgroupviewitem.h > e691e66c03cdd631c739875914f80403c5edebc7 > plugins/alias/aliaspreferences.cpp 19e54202e8978e27e354cc2014ffde1d39714dc1 > plugins/alias/editaliasdialog.cpp fed313c237de3fc18c8e4de298c74a641011675f > plugins/highlight/highlightpreferences.cpp > 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 > protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 > protocols/groupwise/ui/gwcontactproperties.cpp > c383585d1744053ffd09ee04a0629661839526ea > > Diff: https://git.reviewboard.kde.org/r/123489/diff/ > > > Testing > ------- > > Compiled and ran kopete shell application. No exceptions or warnings thrown. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
