----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119568/#review65656 -----------------------------------------------------------
Hello, sorry but I forgot about this review request. Here are my comments: Non critical/bugfix changes in kopete protocols/jabber/libiris/ will not be accepted because libiris is periodically pulled from upstream repository: https://github.com/psi-im/iris If you want to change code in libiris please do that in upstream. Other kopete changes are marked "for old broken gcc". I have no idea what that mean so it will be good to find out that first. - Pali Rohár On sep. 1, 2014, 7:26 popoludní, Arnold Dumas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119568/ > ----------------------------------------------------------- > > (Updated sep. 1, 2014, 7:26 popoludní) > > > Review request for Kopete and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > QString::null makes no sense theses days. > > > Diffs > ----- > > protocols/jabber/libiris/src/xmpp/xmpp-core/parser.cpp 0c5b9ae > protocols/jabber/libiris/src/xmpp/xmpp-im/filetransfer.h 63c53b4 > protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_discoinfotask.h bda6842 > protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_discoitem.cpp 59e9551 > protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_tasks.h e4afcd0 > protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_xdata.cpp 16bd85b > protocols/jabber/libiris/src/xmpp/xmpp-im/xmpp_xmlcommon.cpp 108dc04 > protocols/qq/qqcontact.cpp a7b60f1 > kopete/chatwindow/kopetechatwindow.cpp 9df17a5 > kopete/contactlist/kopetecontactlistview.cpp 7bf3c24 > kopete/identity/identitydialog.cpp 8d8af6c > libkopete/kopetecommandhandler.cpp f523f4b > libkopete/kopetepassword.cpp eaa9d9a > libkopete/kopetepasswordedaccount.cpp ca33d33 > libkopete/kopetepluginmanager.cpp 4469211 > libkopete/ui/addressbookselectorwidget.cpp a02a61b > libkopete/ui/contactaddednotifydialog.h af803e7 > protocols/jabber/libiris/src/xmpp/xmpp-core/parser.h b5a3b3d > > Diff: https://git.reviewboard.kde.org/r/119568/diff/ > > > Testing > ------- > > It compiles > > > Thanks, > > Arnold Dumas > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
