> On April 13, 2014, 9:05 a.m., Pali Rohár wrote: > > cmake/modules/FindEV.cmake, line 1 > > <https://git.reviewboard.kde.org/r/116605/diff/3/?file=257450#file257450line1> > > > > Where are you using cmake/modules/FindEV.cmake and > > cmake/modules/FindMozJS.cmake modules? > > zhang jun wrote: > I find the lwqq associated libraries are put FindLiblwqq.cmake. > > Pali Rohár wrote: > In top level CMakeLists.txt you added only > macro_optional_find_package(Liblwqq) and in protocols/CMakeLists.txt you > added only if(WITH_qq AND LIBLWQQ_FOUND). I do not see place where is EV and > MozJS uses. No other find_package command command. > > zhang jun wrote: > In FindLiblwqq.cmake file, the use find_package (EV) and > pkg_check_modules (MOZJS mozjs185) to find EV and MOZJS. > > Pali Rohár wrote: > pkg_check_modules using pkgconfig program, not internal cmake > find_package, so cmake/modules/FindMozJS.cmake is not used.
Thank you, indeed FindMozJS.cmake not used. > On April 13, 2014, 9:05 a.m., Pali Rohár wrote: > > protocols/qq/CMakeLists.txt, line 7 > > <https://git.reviewboard.kde.org/r/116605/diff/3/?file=257454#file257454line7> > > > > Please avoid using gcc specific flags. Do you really need it? > > zhang jun wrote: > Since liblwqq c prepared, and use a lot of calls casts, if do not use > -fpermissive option appears a lot of mistakes. > > Pali Rohár wrote: > If liblwqq is C library then it is better to use C compiler instead C++. > And not adding gcc hacks... > > zhang jun wrote: > liblwqq library is indeed using c compiler, but in C + + code in a large > number of calls liblwqq interface, and uses a lot of > type conversion. > > Pali Rohár wrote: > Ok, then please wrap g++ specific flags into cmake condition > if(CMAKE_COMPILER_IS_GNUCXX) OK - zhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116605/#review55566 ----------------------------------------------------------- On April 14, 2014, 9:14 a.m., zhang jun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116605/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 9:14 a.m.) > > > Review request for Kopete. > > > Repository: kopete > > > Description > ------- > > Because qq kopete previous protocol have not used, so the basis of an > protocol with Lwqq: https://github.com/xiehuc/lwqq.git, now realize the basic > functions, as well as some bug to be repaired.now git > Address:http://git.oschina.net/zhjun5337/kopete-qq.git > > > Diffs > ----- > > CMakeLists.txt 06e11aa > cmake/modules/FindEV.cmake PRE-CREATION > cmake/modules/FindLiblwqq.cmake PRE-CREATION > protocols/CMakeLists.txt e83d591 > protocols/qq/CMakeLists.txt 00640b2 > protocols/qq/README 0078f0d > protocols/qq/crypt.h cdba83e > protocols/qq/crypt.cpp a011f0c > protocols/qq/emoticons/CMakeLists.txt PRE-CREATION > protocols/qq/emoticons/Webqq/0.gif PRE-CREATION > protocols/qq/emoticons/Webqq/1.gif PRE-CREATION > protocols/qq/emoticons/Webqq/10.gif PRE-CREATION > protocols/qq/emoticons/Webqq/100.gif PRE-CREATION > protocols/qq/emoticons/Webqq/101.gif PRE-CREATION > protocols/qq/emoticons/Webqq/102.gif PRE-CREATION > protocols/qq/emoticons/Webqq/103.gif PRE-CREATION > protocols/qq/emoticons/Webqq/104.gif PRE-CREATION > protocols/qq/emoticons/Webqq/105.gif PRE-CREATION > protocols/qq/emoticons/Webqq/106.gif PRE-CREATION > protocols/qq/emoticons/Webqq/107.gif PRE-CREATION > protocols/qq/emoticons/Webqq/108.gif PRE-CREATION > protocols/qq/emoticons/Webqq/109.gif PRE-CREATION > protocols/qq/emoticons/Webqq/11.gif PRE-CREATION > protocols/qq/emoticons/Webqq/110.gif PRE-CREATION > protocols/qq/emoticons/Webqq/111.gif PRE-CREATION > protocols/qq/emoticons/Webqq/112.gif PRE-CREATION > protocols/qq/emoticons/Webqq/113.gif PRE-CREATION > protocols/qq/emoticons/Webqq/114.gif PRE-CREATION > protocols/qq/emoticons/Webqq/115.gif PRE-CREATION > protocols/qq/emoticons/Webqq/116.gif PRE-CREATION > protocols/qq/emoticons/Webqq/117.gif PRE-CREATION > protocols/qq/emoticons/Webqq/118.gif PRE-CREATION > protocols/qq/emoticons/Webqq/119.gif PRE-CREATION > protocols/qq/emoticons/Webqq/12.gif PRE-CREATION > protocols/qq/emoticons/Webqq/120.gif PRE-CREATION > protocols/qq/emoticons/Webqq/121.gif PRE-CREATION > protocols/qq/emoticons/Webqq/122.gif PRE-CREATION > protocols/qq/emoticons/Webqq/123.gif PRE-CREATION > protocols/qq/emoticons/Webqq/124.gif PRE-CREATION > protocols/qq/emoticons/Webqq/125.gif PRE-CREATION > protocols/qq/emoticons/Webqq/126.gif PRE-CREATION > protocols/qq/emoticons/Webqq/127.gif PRE-CREATION > protocols/qq/emoticons/Webqq/128.gif PRE-CREATION > protocols/qq/emoticons/Webqq/129.gif PRE-CREATION > protocols/qq/emoticons/Webqq/13.gif PRE-CREATION > protocols/qq/emoticons/Webqq/130.gif PRE-CREATION > protocols/qq/emoticons/Webqq/131.gif PRE-CREATION > protocols/qq/emoticons/Webqq/132.gif PRE-CREATION > protocols/qq/emoticons/Webqq/133.gif PRE-CREATION > protocols/qq/emoticons/Webqq/134.gif PRE-CREATION > protocols/qq/emoticons/Webqq/14.gif PRE-CREATION > protocols/qq/emoticons/Webqq/15.gif PRE-CREATION > protocols/qq/emoticons/Webqq/16.gif PRE-CREATION > protocols/qq/emoticons/Webqq/17.gif PRE-CREATION > protocols/qq/emoticons/Webqq/18.gif PRE-CREATION > protocols/qq/emoticons/Webqq/19.gif PRE-CREATION > protocols/qq/emoticons/Webqq/2.gif PRE-CREATION > protocols/qq/emoticons/Webqq/20.gif PRE-CREATION > protocols/qq/emoticons/Webqq/21.gif PRE-CREATION > protocols/qq/emoticons/Webqq/22.gif PRE-CREATION > protocols/qq/emoticons/Webqq/23.gif PRE-CREATION > protocols/qq/emoticons/Webqq/24.gif PRE-CREATION > protocols/qq/emoticons/Webqq/25.gif PRE-CREATION > protocols/qq/emoticons/Webqq/26.gif PRE-CREATION > protocols/qq/emoticons/Webqq/27.gif PRE-CREATION > protocols/qq/emoticons/Webqq/28.gif PRE-CREATION > protocols/qq/emoticons/Webqq/29.gif PRE-CREATION > protocols/qq/emoticons/Webqq/3.gif PRE-CREATION > protocols/qq/emoticons/Webqq/30.gif PRE-CREATION > protocols/qq/emoticons/Webqq/31.gif PRE-CREATION > protocols/qq/emoticons/Webqq/32.gif PRE-CREATION > protocols/qq/emoticons/Webqq/33.gif PRE-CREATION > protocols/qq/emoticons/Webqq/34.gif PRE-CREATION > protocols/qq/emoticons/Webqq/35.gif PRE-CREATION > protocols/qq/emoticons/Webqq/36.gif PRE-CREATION > protocols/qq/emoticons/Webqq/37.gif PRE-CREATION > protocols/qq/emoticons/Webqq/38.gif PRE-CREATION > protocols/qq/emoticons/Webqq/39.gif PRE-CREATION > protocols/qq/emoticons/Webqq/4.gif PRE-CREATION > protocols/qq/emoticons/Webqq/40.gif PRE-CREATION > protocols/qq/emoticons/Webqq/41.gif PRE-CREATION > protocols/qq/emoticons/Webqq/42.gif PRE-CREATION > protocols/qq/emoticons/Webqq/43.gif PRE-CREATION > protocols/qq/emoticons/Webqq/44.gif PRE-CREATION > protocols/qq/emoticons/Webqq/45.gif PRE-CREATION > protocols/qq/emoticons/Webqq/46.gif PRE-CREATION > protocols/qq/emoticons/Webqq/47.gif PRE-CREATION > protocols/qq/emoticons/Webqq/48.gif PRE-CREATION > protocols/qq/emoticons/Webqq/49.gif PRE-CREATION > protocols/qq/emoticons/Webqq/5.gif PRE-CREATION > protocols/qq/emoticons/Webqq/50.gif PRE-CREATION > protocols/qq/emoticons/Webqq/51.gif PRE-CREATION > protocols/qq/emoticons/Webqq/52.gif PRE-CREATION > protocols/qq/emoticons/Webqq/53.gif PRE-CREATION > protocols/qq/emoticons/Webqq/54.gif PRE-CREATION > protocols/qq/emoticons/Webqq/55.gif PRE-CREATION > protocols/qq/emoticons/Webqq/56.gif PRE-CREATION > protocols/qq/emoticons/Webqq/57.gif PRE-CREATION > protocols/qq/emoticons/Webqq/58.gif PRE-CREATION > protocols/qq/emoticons/Webqq/59.gif PRE-CREATION > protocols/qq/emoticons/Webqq/6.gif PRE-CREATION > protocols/qq/emoticons/Webqq/60.gif PRE-CREATION > protocols/qq/emoticons/Webqq/61.gif PRE-CREATION > protocols/qq/emoticons/Webqq/62.gif PRE-CREATION > protocols/qq/emoticons/Webqq/63.gif PRE-CREATION > protocols/qq/emoticons/Webqq/64.gif PRE-CREATION > protocols/qq/emoticons/Webqq/65.gif PRE-CREATION > protocols/qq/emoticons/Webqq/66.gif PRE-CREATION > protocols/qq/emoticons/Webqq/67.gif PRE-CREATION > protocols/qq/emoticons/Webqq/68.gif PRE-CREATION > protocols/qq/emoticons/Webqq/69.gif PRE-CREATION > protocols/qq/emoticons/Webqq/7.gif PRE-CREATION > protocols/qq/emoticons/Webqq/70.gif PRE-CREATION > protocols/qq/emoticons/Webqq/71.gif PRE-CREATION > protocols/qq/emoticons/Webqq/72.gif PRE-CREATION > protocols/qq/emoticons/Webqq/73.gif PRE-CREATION > protocols/qq/emoticons/Webqq/74.gif PRE-CREATION > protocols/qq/emoticons/Webqq/75.gif PRE-CREATION > protocols/qq/emoticons/Webqq/76.gif PRE-CREATION > protocols/qq/emoticons/Webqq/77.gif PRE-CREATION > protocols/qq/emoticons/Webqq/78.gif PRE-CREATION > protocols/qq/emoticons/Webqq/79.gif PRE-CREATION > protocols/qq/emoticons/Webqq/8.gif PRE-CREATION > protocols/qq/emoticons/Webqq/80.gif PRE-CREATION > protocols/qq/emoticons/Webqq/81.gif PRE-CREATION > protocols/qq/emoticons/Webqq/82.gif PRE-CREATION > protocols/qq/emoticons/Webqq/83.gif PRE-CREATION > protocols/qq/emoticons/Webqq/84.gif PRE-CREATION > protocols/qq/emoticons/Webqq/85.gif PRE-CREATION > protocols/qq/emoticons/Webqq/86.gif PRE-CREATION > protocols/qq/emoticons/Webqq/87.gif PRE-CREATION > protocols/qq/emoticons/Webqq/88.gif PRE-CREATION > protocols/qq/emoticons/Webqq/89.gif PRE-CREATION > protocols/qq/emoticons/Webqq/9.gif PRE-CREATION > protocols/qq/emoticons/Webqq/90.gif PRE-CREATION > protocols/qq/emoticons/Webqq/91.gif PRE-CREATION > protocols/qq/emoticons/Webqq/92.gif PRE-CREATION > protocols/qq/emoticons/Webqq/93.gif PRE-CREATION > protocols/qq/emoticons/Webqq/94.gif PRE-CREATION > protocols/qq/emoticons/Webqq/95.gif PRE-CREATION > protocols/qq/emoticons/Webqq/96.gif PRE-CREATION > protocols/qq/emoticons/Webqq/97.gif PRE-CREATION > protocols/qq/emoticons/Webqq/98.gif PRE-CREATION > protocols/qq/emoticons/Webqq/99.gif PRE-CREATION > protocols/qq/emoticons/Webqq/emoticons.xml PRE-CREATION > protocols/qq/emoticons/Webqq/theme PRE-CREATION > protocols/qq/emoticons/Webqq/toggleface.png PRE-CREATION > protocols/qq/evautil.cpp 9b357ef > protocols/qq/icons/CMakeLists.txt 321add4 > protocols/qq/icons/cr16-action-qq_connecting.mng > a52a9fd1f8fd68e0f8deded5b192c8bc2a3c7cf4 > protocols/qq/icons/cr22-action-qq_connecting.mng > cd61ac4a3f32feaabd99efc5314e69d91e1b6745 > protocols/qq/icons/cr32-action-qq_connecting.mng > cf10297d9af7692b1f88d234fbf088c82b165d20 > protocols/qq/icons/cr48-action-qq_connecting.mng > c70e87af232b954258f28a5b8265ca9ea3c7d964 > protocols/qq/icons/cr64-action-qq_connecting.mng > a121cabf1b06924ba027eba65caf048209dae472 > protocols/qq/icons/ox128-app-qq_protocol.png > 966e3126e69f97fce23026a047f04025e90beccc > protocols/qq/icons/ox16-app-qq_protocol.png > 22d950ef9984cf2b3a046fb21d6d2e827b3e45c7 > protocols/qq/icons/ox22-app-qq_protocol.png > 45da0df5546b6c9130e6289d9e8102d208e7ac3c > protocols/qq/icons/ox32-app-qq_protocol.png > 5c1d09003dd3cf018dcc3b84d743805d3a493a43 > protocols/qq/icons/ox48-app-qq_protocol.png > dbf0307b3225e759dab459825a8c87c8791b2777 > protocols/qq/icons/ox64-app-qq_protocol.png > 167ea044bd0c1170ebc51ed6e4e651fc2f91b88b > protocols/qq/js.h PRE-CREATION > protocols/qq/js.cpp PRE-CREATION > protocols/qq/kopete_qq.desktop 9bcd3a6 > protocols/qq/libeva.h 9116052 > protocols/qq/libeva.cpp 64c5e22 > protocols/qq/liblwqq/CMakeLists.txt PRE-CREATION > protocols/qq/liblwqq/config.h.in PRE-CREATION > protocols/qq/liblwqq/lib/CMakeLists.txt PRE-CREATION > protocols/qq/liblwqq/lib/async.h PRE-CREATION > protocols/qq/liblwqq/lib/async.c PRE-CREATION > protocols/qq/liblwqq/lib/async_impl.h PRE-CREATION > protocols/qq/liblwqq/lib/async_libev.c PRE-CREATION > protocols/qq/liblwqq/lib/async_libuv.c PRE-CREATION > protocols/qq/liblwqq/lib/config.h PRE-CREATION > protocols/qq/liblwqq/lib/http.h PRE-CREATION > protocols/qq/liblwqq/lib/http.c PRE-CREATION > protocols/qq/liblwqq/lib/info.h PRE-CREATION > protocols/qq/liblwqq/lib/info.c PRE-CREATION > protocols/qq/liblwqq/lib/internal.h PRE-CREATION > protocols/qq/liblwqq/lib/internal.c PRE-CREATION > protocols/qq/liblwqq/lib/json.h PRE-CREATION > protocols/qq/liblwqq/lib/json.c PRE-CREATION > protocols/qq/liblwqq/lib/logger.h PRE-CREATION > protocols/qq/liblwqq/lib/logger.c PRE-CREATION > protocols/qq/liblwqq/lib/login.h PRE-CREATION > protocols/qq/liblwqq/lib/login.c PRE-CREATION > protocols/qq/liblwqq/lib/lwdb.h PRE-CREATION > protocols/qq/liblwqq/lib/lwdb.c PRE-CREATION > protocols/qq/liblwqq/lib/lwjs.h PRE-CREATION > protocols/qq/liblwqq/lib/lwjs.c PRE-CREATION > protocols/qq/liblwqq/lib/lwqq-config.h PRE-CREATION > protocols/qq/liblwqq/lib/lwqq.h PRE-CREATION > protocols/qq/liblwqq/lib/md5.h PRE-CREATION > protocols/qq/liblwqq/lib/md5.c PRE-CREATION > protocols/qq/liblwqq/lib/msg.h PRE-CREATION > protocols/qq/liblwqq/lib/msg.c PRE-CREATION > protocols/qq/liblwqq/lib/queue.h PRE-CREATION > protocols/qq/liblwqq/lib/smemory.h PRE-CREATION > protocols/qq/liblwqq/lib/smemory.c PRE-CREATION > protocols/qq/liblwqq/lib/swsqlite.h PRE-CREATION > protocols/qq/liblwqq/lib/swsqlite.c PRE-CREATION > protocols/qq/liblwqq/lib/type.h PRE-CREATION > protocols/qq/liblwqq/lib/type.c PRE-CREATION > protocols/qq/liblwqq/lib/url.h PRE-CREATION > protocols/qq/liblwqq/lib/url.c PRE-CREATION > protocols/qq/liblwqq/lib/utility.h PRE-CREATION > protocols/qq/liblwqq/lib/utility.c PRE-CREATION > protocols/qq/liblwqq/lib/vplist.h PRE-CREATION > protocols/qq/liblwqq/lib/vplist.c PRE-CREATION > protocols/qq/liblwqq/lib/win32.h PRE-CREATION > protocols/qq/liblwqq/lib/win32.c PRE-CREATION > protocols/qq/md5.h 501cdbe > protocols/qq/md5.c 25ddccb > protocols/qq/qq_types.h PRE-CREATION > protocols/qq/qq_types.cpp PRE-CREATION > protocols/qq/qqaccount.h 94f17b1 > protocols/qq/qqaccount.cpp 710d0c7 > protocols/qq/qqaddcontactpage.h cfa2d45 > protocols/qq/qqaddcontactpage.cpp 8cfd032 > protocols/qq/qqchatsession.h 095a55f > protocols/qq/qqchatsession.cpp 6ae8827 > protocols/qq/qqchatui.rc 21e6475 > protocols/qq/qqcontact.h 8aaefc1 > protocols/qq/qqcontact.cpp 13945ac > protocols/qq/qqnotifysocket.h 6f956c7 > protocols/qq/qqnotifysocket.cpp ea478bd > protocols/qq/qqprotocol.h 404b516 > protocols/qq/qqprotocol.cpp 321aafa > protocols/qq/qqsocket.h cdcbb1c > protocols/qq/qqsocket.cpp cfd06bc > protocols/qq/translate.h PRE-CREATION > protocols/qq/translate.cpp PRE-CREATION > protocols/qq/trex.h PRE-CREATION > protocols/qq/trex.cpp PRE-CREATION > protocols/qq/ui/dlgqqvcard.h ed2fb53 > protocols/qq/ui/dlgqqvcard.cpp 2209a01 > protocols/qq/ui/qqaddui.ui ee37409 > protocols/qq/ui/qqeditaccountui.ui d4ba08f > protocols/qq/ui/qqeditaccountwidget.h 121fdc4 > protocols/qq/ui/qqeditaccountwidget.cpp 940911f > protocols/qq/ui/qqvcard.ui 8041731 > protocols/qq/ui/qqwebcamdialog.h c6dd388 > protocols/qq/ui/qqwebcamdialog.cpp 4049de7 > protocols/qq/ui/webqqwebcamdialog.h PRE-CREATION > protocols/qq/ui/webqqwebcamdialog.cpp PRE-CREATION > protocols/qq/webqqaccount.h PRE-CREATION > protocols/qq/webqqaccount.cpp PRE-CREATION > protocols/qq/webqqaccountpreferences.ui PRE-CREATION > protocols/qq/webqqaddcontactpage.h PRE-CREATION > protocols/qq/webqqaddcontactpage.cpp PRE-CREATION > protocols/qq/webqqaddui.ui PRE-CREATION > protocols/qq/webqqbridgecallback.h PRE-CREATION > protocols/qq/webqqbridgecallback.cpp PRE-CREATION > protocols/qq/webqqchatsession.h PRE-CREATION > protocols/qq/webqqchatsession.cpp PRE-CREATION > protocols/qq/webqqchatui.rc PRE-CREATION > protocols/qq/webqqcontact.h PRE-CREATION > protocols/qq/webqqcontact.cpp PRE-CREATION > protocols/qq/webqqdiscuchatsession.h PRE-CREATION > protocols/qq/webqqdiscuchatsession.cpp PRE-CREATION > protocols/qq/webqqdiscuui.rc PRE-CREATION > protocols/qq/webqqeditaccountwidget.h PRE-CREATION > protocols/qq/webqqeditaccountwidget.cpp PRE-CREATION > protocols/qq/webqqfakeserver.h PRE-CREATION > protocols/qq/webqqfakeserver.cpp PRE-CREATION > protocols/qq/webqqgroupchatsession.h PRE-CREATION > protocols/qq/webqqgroupchatsession.cpp PRE-CREATION > protocols/qq/webqqgroupui.rc PRE-CREATION > protocols/qq/webqqincomingmessage.h PRE-CREATION > protocols/qq/webqqincomingmessage.cpp PRE-CREATION > protocols/qq/webqqloginverify.ui PRE-CREATION > protocols/qq/webqqloginverifywidget.h PRE-CREATION > protocols/qq/webqqloginverifywidget.cpp PRE-CREATION > protocols/qq/webqqprotocol.h PRE-CREATION > protocols/qq/webqqprotocol.cpp PRE-CREATION > protocols/qq/webqqshowgetinfo.h PRE-CREATION > protocols/qq/webqqshowgetinfo.cpp PRE-CREATION > protocols/qq/webqquserinfoform.h PRE-CREATION > protocols/qq/webqquserinfoform.cpp PRE-CREATION > protocols/qq/webqquserinfoform.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116605/diff/ > > > Testing > ------- > > > Thanks, > > zhang jun > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
