----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115693/#review55565 -----------------------------------------------------------
libkopete/kopetecontact.cpp <https://git.reviewboard.kde.org/r/115693/#comment38658> I think enabling this only for yahoo protocol is bad idea. Jabber and ICQ protocols support sending files to invisible users too... And using protocol()->displayName() here is ugly. Rather remove isOnline() check or add some new attribute for protocol code to support sennding files to offline/invisible users. - Pali Rohár On Feb. 12, 2014, 10:59 a.m., Ovidiu Nitan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115693/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 10:59 a.m.) > > > Review request for Kopete. > > > Repository: kopete > > > Description > ------- > > On YMSG, Kopete doesn't allow to send files to users which appears to be > offline. While is impossible for a Yahoo! Messenger user to receive a file > when offline, it is possible to receive files when it appears to be offline > (aka when he is invisible). This patch enables the sending of files for YMSG > users which appears offline to us. > > > Diffs > ----- > > libkopete/kopetecontact.cpp 054a0b0 > > Diff: https://git.reviewboard.kde.org/r/115693/diff/ > > > Testing > ------- > > > Thanks, > > Ovidiu Nitan > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
