> On March 5, 2014, 8:42 a.m., Pali Rohár wrote: > > There is already qq protocol in Kopete git tree: > > https://projects.kde.org/projects/kde/kdenetwork/kopete/repository/revisions/master/show/protocols/qq > > > > So what is reason for adding another implementation of qq protocol? > > Existing code does not working anymore? > > zhang jun wrote: > Because qq protocol changes is very large, the original can not work > properly, according to the original code modification works very large.
If current implementation in kopete tree is not usable, I suggest to replace it with this new. And not to add another implementation. Can you do it (also to make sure that existing kopete accounts in config file will work fine with new code)? - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116605/#review52012 ----------------------------------------------------------- On March 5, 2014, 4:48 a.m., zhang jun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116605/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 4:48 a.m.) > > > Review request for Kopete. > > > Repository: kopete > > > Description > ------- > > Because qq kopete previous protocol have not used, so the basis of an > protocol with Lwqq: https://github.com/xiehuc/lwqq.git, now realize the basic > functions, as well as some bug to be repaired.now git > Address:http://git.oschina.net/zhjun5337/kopete-qq.git > > > Diffs > ----- > > protocols/webqq/webqquserinfoform.ui PRE-CREATION > protocols/webqq/webqquserinfoform.cpp PRE-CREATION > protocols/webqq/webqquserinfoform.h PRE-CREATION > protocols/webqq/webqqshowgetinfo.cpp PRE-CREATION > protocols/webqq/webqqprotocol.cpp PRE-CREATION > protocols/webqq/webqqshowgetinfo.h PRE-CREATION > protocols/webqq/webqqprotocol.h PRE-CREATION > protocols/webqq/webqqloginverifywidget.cpp PRE-CREATION > protocols/webqq/webqqloginverifywidget.h PRE-CREATION > protocols/webqq/webqqloginverify.ui PRE-CREATION > protocols/webqq/webqqincomingmessage.cpp PRE-CREATION > protocols/webqq/webqqgroupui.rc PRE-CREATION > protocols/webqq/webqqincomingmessage.h PRE-CREATION > protocols/webqq/webqqgroupchatsession.cpp PRE-CREATION > protocols/webqq/webqqgroupchatsession.h PRE-CREATION > protocols/webqq/webqqfakeserver.h PRE-CREATION > protocols/webqq/webqqfakeserver.cpp PRE-CREATION > protocols/webqq/webqqeditaccountwidget.cpp PRE-CREATION > protocols/webqq/webqqeditaccountwidget.h PRE-CREATION > protocols/webqq/webqqdiscuui.rc PRE-CREATION > protocols/webqq/webqqdiscuchatsession.h PRE-CREATION > protocols/webqq/webqqdiscuchatsession.cpp PRE-CREATION > protocols/webqq/webqqcontact.cpp PRE-CREATION > protocols/webqq/webqqcontact.h PRE-CREATION > protocols/webqq/webqqchatsession.cpp PRE-CREATION > protocols/webqq/webqqchatui.rc PRE-CREATION > protocols/webqq/webqqchatsession.h PRE-CREATION > protocols/webqq/webqqbridgecallback.cpp PRE-CREATION > protocols/webqq/webqqbridgecallback.h PRE-CREATION > protocols/webqq/webqqaddui.ui PRE-CREATION > protocols/webqq/webqqaddcontactpage.cpp PRE-CREATION > protocols/webqq/webqqaddcontactpage.h PRE-CREATION > protocols/webqq/webqqaccountpreferences.ui PRE-CREATION > protocols/webqq/webqqaccount.cpp PRE-CREATION > protocols/webqq/ui/webqqwebcamdialog.cpp PRE-CREATION > protocols/webqq/webqqaccount.h PRE-CREATION > protocols/webqq/ui/webqqwebcamdialog.h PRE-CREATION > protocols/webqq/trex.cpp PRE-CREATION > protocols/webqq/trex.h PRE-CREATION > protocols/webqq/translate.cpp PRE-CREATION > protocols/webqq/qq_types.cpp PRE-CREATION > protocols/webqq/translate.h PRE-CREATION > protocols/webqq/qq_types.h PRE-CREATION > protocols/webqq/liblwqq/src/cli.c PRE-CREATION > protocols/webqq/liblwqq/lib/win32.c PRE-CREATION > protocols/webqq/liblwqq/src/CMakeLists.txt PRE-CREATION > protocols/webqq/liblwqq/lib/win32.h PRE-CREATION > protocols/webqq/liblwqq/lib/vplist.c PRE-CREATION > protocols/webqq/liblwqq/lib/vplist.h PRE-CREATION > protocols/webqq/liblwqq/lib/utility.h PRE-CREATION > protocols/webqq/liblwqq/lib/utility.c PRE-CREATION > protocols/webqq/liblwqq/lib/url.c PRE-CREATION > protocols/webqq/liblwqq/lib/url.h PRE-CREATION > protocols/webqq/liblwqq/lib/type.c PRE-CREATION > protocols/webqq/liblwqq/lib/type.h PRE-CREATION > protocols/webqq/liblwqq/lib/swsqlite.c PRE-CREATION > protocols/webqq/liblwqq/lib/swsqlite.h PRE-CREATION > protocols/webqq/liblwqq/lib/smemory.h PRE-CREATION > protocols/webqq/liblwqq/lib/smemory.c PRE-CREATION > protocols/webqq/liblwqq/lib/queue.h PRE-CREATION > protocols/webqq/liblwqq/lib/msg.c PRE-CREATION > protocols/webqq/liblwqq/lib/msg.h PRE-CREATION > protocols/webqq/liblwqq/lib/md5.h PRE-CREATION > protocols/webqq/liblwqq/lib/md5.c PRE-CREATION > protocols/webqq/liblwqq/lib/lwqq.h PRE-CREATION > protocols/webqq/liblwqq/lib/lwqq-config.h PRE-CREATION > protocols/webqq/liblwqq/lib/lwjs.c PRE-CREATION > protocols/webqq/liblwqq/lib/lwjs.h PRE-CREATION > protocols/webqq/liblwqq/lib/lwdb.c PRE-CREATION > protocols/webqq/liblwqq/lib/lwdb.h PRE-CREATION > protocols/webqq/liblwqq/lib/login.c PRE-CREATION > protocols/webqq/liblwqq/lib/login.h PRE-CREATION > protocols/webqq/liblwqq/lib/logger.c PRE-CREATION > protocols/webqq/liblwqq/lib/logger.h PRE-CREATION > protocols/webqq/liblwqq/lib/json.h PRE-CREATION > protocols/webqq/liblwqq/lib/json.c PRE-CREATION > protocols/webqq/liblwqq/lib/internal.c PRE-CREATION > protocols/webqq/liblwqq/lib/internal.h PRE-CREATION > protocols/webqq/liblwqq/lib/info.c PRE-CREATION > protocols/webqq/liblwqq/lib/info.h PRE-CREATION > protocols/webqq/liblwqq/lib/http.c PRE-CREATION > protocols/webqq/liblwqq/lib/http.h PRE-CREATION > protocols/webqq/liblwqq/lib/config.h PRE-CREATION > protocols/webqq/liblwqq/lib/async_libuv.c PRE-CREATION > protocols/webqq/liblwqq/lib/async_libev.c PRE-CREATION > protocols/webqq/liblwqq/lib/async_impl.h PRE-CREATION > protocols/webqq/liblwqq/lib/async.c PRE-CREATION > protocols/webqq/CMakeLists.txt PRE-CREATION > protocols/webqq/README.md PRE-CREATION > protocols/webqq/cmake/modules/FindJsonCpp.cmake PRE-CREATION > protocols/webqq/cmake/modules/FindKopete.cmake PRE-CREATION > protocols/webqq/cmake/modules/FindSSL.cmake PRE-CREATION > protocols/webqq/config.h.in PRE-CREATION > protocols/webqq/icons/CMakeLists.txt PRE-CREATION > protocols/webqq/icons/ox128-app-webqq_protocol.png PRE-CREATION > protocols/webqq/icons/ox16-app-webqq_protocol.png PRE-CREATION > protocols/webqq/icons/ox32-app-webqq_protocol.png PRE-CREATION > protocols/webqq/icons/ox48-app-webqq_protocol.png PRE-CREATION > protocols/webqq/icons/ox64-app-webqq_protocol.png PRE-CREATION > protocols/webqq/js.h PRE-CREATION > protocols/webqq/js.cpp PRE-CREATION > protocols/webqq/kopete_webqq.desktop PRE-CREATION > protocols/webqq/liblwqq/CMakeLists.txt PRE-CREATION > protocols/webqq/liblwqq/bindings/python/lwqq/async.py PRE-CREATION > protocols/webqq/liblwqq/bindings/python/lwqq/common.py PRE-CREATION > protocols/webqq/liblwqq/bindings/python/lwqq/core.py PRE-CREATION > protocols/webqq/liblwqq/bindings/python/lwqq/enumerations.py PRE-CREATION > protocols/webqq/liblwqq/bindings/python/lwqq/http.py PRE-CREATION > protocols/webqq/liblwqq/bindings/python/lwqq/vplist.py PRE-CREATION > protocols/webqq/liblwqq/bindings/python/test-login.py PRE-CREATION > protocols/webqq/liblwqq/cmake/FindEV.cmake PRE-CREATION > protocols/webqq/liblwqq/cmake/FindLibuv.cmake PRE-CREATION > protocols/webqq/liblwqq/cmake/FindMozJS.cmake PRE-CREATION > protocols/webqq/liblwqq/cmake/FindSphinx.cmake PRE-CREATION > protocols/webqq/liblwqq/cmake/FindSqlite3.cmake PRE-CREATION > protocols/webqq/liblwqq/config.h.in PRE-CREATION > protocols/webqq/liblwqq/lib/CMakeLists.txt PRE-CREATION > protocols/webqq/liblwqq/lib/async.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116605/diff/ > > > Testing > ------- > > > Thanks, > > zhang jun > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
