El Dilluns, 5 d'agost de 2013, a les 15:23:58, Pali Rohár va escriure: > On Tuesday 30 July 2013 19:43:26 Albert Astals Cid wrote: > > El Dimarts, 30 de juliol de 2013, a les 17:07:45, Pali Rohár va > > escriure: > > > On Tuesday 09 July 2013 00:04:13 Albert Astals Cid wrote: > > > > El Dilluns, 8 de juliol de 2013, a les 20:30:16, Pali > > > > Rohár va > > > > > > escriure: > > > > > On Monday 08 July 2013 19:22:18 Albert Astals Cid wrote: > > > > > > El Dilluns, 8 de juliol de 2013, a les 10:42:33, Pali > > > > > > Rohár va > > > > > > > > > > escriure: > > > > > > > On Monday 08 July 2013 00:27:01 Albert Astals Cid > > wrote: > > > > > > > > *CC me on answers, I'm not subscribed.* > > > > > > > > > > > > > > > > Hi guys, is anyone planning to fix the Kopete unit > > > > > > > > test that fails? > > > > > > > > > > > > > > > > http://build.kde.org/view/KDE%20SC%20master/job/ko > > > > > > > > pete _mas ter/ > > > > > > > > 42/testReport/%28root%29/TestSuite/xmlcontactstora > > > > > > > > ge_t est / > > > > > > > > > > > > > > > > Cheers, > > > > > > > > > > > > > > > > Albert > > > > > > > > > > > > > > Hi, I already look at xmlcontactstorage test. Now > > > > > > > kopete automatically add root group folder to > > > > > > > contact storage if does not exist. In that test xml > > > > > > > file there is no root folder, so kopete adding one. > > > > > > > So this is reason why Actual group size is 5. > > > > > > > > > > > > > > Possible fix for this test is changing expected > > > > > > > group size value from 4 to 5 (becase root folder is > > > > > > > added automatically) or adding root folder to test > > > > > > > xml file (so now root folder will not be added by > > > > > > > kopete). > > > > > > > > > > > > If the expected value is 5, change the test to expect > > > > > > a 5 not a 4 :-) > > > > > > > > > > > > Cheers, > > > > > > > > > > > > Albert > > > > > > > > > > Ok, commited to master. > > > > > > > > Seems that it still fails (a few lines down the test). > > > > > > > > Can you have a look? > > > > > > > > http://build.kde.org/view/KDE%20SC%20master/job/kopete_mas > > > > ter/ > > > > 43/testReport/%28root%29/TestSuite/xmlcontactstorage_test > > > > / > > > > > > > > Thanks, > > > > > > > > Albert > > > > > > Hello, finally I find time and tried to fix this test. > > > Problem was not only in test but also in kopete code. > > > > Awesome, tests being useful :-) > > > > > I pushed two commits to > > > kopete master. Please look at them if patches really fixing > > > test problem. And if yes maybe consider adding them to > > > KDE/4.11. > > > > I guess that's up to you or other kopete guys to decide if you > > feel safe backporting the changes or not, my knowledge of the > > kopete code is zero. > > > > Cheers, > > > > Albert > > Ok, I pushed that two commits to KDE/4.11 and I pushed also other > one which finally should fix binary compatibility with KDE 4.10.
Awesome! Cheers, Albert _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
