> On July 4, 2013, 11:28 a.m., Pali Rohár wrote: > > As Peter suggested, consider also support for XEP-0313. Or at least prepare > > your patch for adding XEP-0313 support. > > So somebody in future will be able to add XEP-0313 without rewriting all > > your code. > > > > If I understand your work correctly, it is needed also new code for kopete > > history plugin to test if everything working fine. > > So this patch will be commited to kopete master together with patch for > > history plugin after testing. > > > > Some other notes to patch: > > * Use same coding style as is in rest of current edited file. In some > > source files is used TAB, but you used four spaces. > > * UI files contains lot of whitespace changes which increasing size of > > patch and hide your real changes. > > > > If you have problems with whitespaces, generate patch with command git diff > > -w (-w ignoring whitespace changes) and then upload it to reviewboard. > > Roman Nazarenko wrote: > XEP-0313 is not ready yet. It's not really even about to be so. It's just > an experimental research, which is both not even a draft and not fully > compatible with the XEP-0136 draft, so, if I would write it's implementation, > THIS would the exact part one will do a "rewriting all your code" with. > There's only one same part in them, the Resilt Set Management, which is a > separate extension and my implementation is ready to be used with XEP-0313 as > well as some common stanzas builders. > > Alright, I shall try to make this spaces-independent diff a bit later.
Ok. If both XEPs are totally different, then at least create some common API for access archive, so kopete history plugin can access history easier. > On July 4, 2013, 11:28 a.m., Pali Rohár wrote: > > protocols/jabber/jabberclient.h, line 358 > > <http://git.reviewboard.kde.org/r/111361/diff/1/?file=167074#file167074line358> > > > > use TAB here > > Roman Nazarenko wrote: > If I understand you correctly, you require me to use tabular key for > indentation? This is kinda prohibited by the KDELibs coding style guidelines, > which, I assume, Kopete should inherit. Let me know if I'm wrong and I shall > take a look at the Qt Creator's indentationing options, though, tabs are > prohibited not without a reason. Problem is that in kopete are used more coding styles. And I want to see at least one coding style in specified file. In file jabberclient.h are used TABs instead spaces and mixing both looks horrible. There are more problems in your patch, not only in jabberclient.h. But for future it could be nice to have all kopete files formatted in same coding style (kdelibs or something other)... Is there any tool which can reformat source files? - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111361/#review35559 ----------------------------------------------------------- On July 2, 2013, 2:34 p.m., Roman Nazarenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111361/ > ----------------------------------------------------------- > > (Updated July 2, 2013, 2:34 p.m.) > > > Review request for Kopete. > > > Description > ------- > > Standard draft: http://xmpp.org/extensions/xep-0136.html > Github repo: https://github.com/Jtalk/kopete-fork-xep0136/tree/XEP-0136 > > This is an Iris task for message archiving support. > I also added appropriate tab to the XMPP account editing widget. > > I have implemented preferences setting, chats collections retrieval and chat > logs retrieval. Comments inside the code will give you some extra information > about this alpha's restructions and problems. We also need History plugin to > be patched to make this thing work. > > > Diffs > ----- > > protocols/jabber/ui/jabbereditaccountwidget.cpp 75cc7c1 > protocols/jabber/ui/jabbereditaccountwidget.h 07f7e70 > protocols/jabber/ui/dlgjabbereditaccountwidget.ui 0f819ae > protocols/jabber/tasks/jt_archive.cpp PRE-CREATION > protocols/jabber/tasks/jt_archive.h PRE-CREATION > protocols/jabber/jabberclient.cpp bc3f37b > protocols/jabber/jabberclient.h 6d791c0 > protocols/jabber/CMakeLists.txt f0c64d3 > > Diff: http://git.reviewboard.kde.org/r/111361/diff/ > > > Testing > ------- > > Click-click, it works. > I also checked collections retrieval, but that code is vanished from the > final version. Worked well though. > > > Thanks, > > Roman Nazarenko > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
