----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6998/#review11056 -----------------------------------------------------------
For me patch is OK, just fix whitespace chars (there are more, not all are marked). Make sure that plugin will be disabled by default and commit it. /trunk/KDE/kdenetwork/kopete/plugins/history2/CMakeLists.txt <http://svn.reviewboard.kde.org/r/6998/#comment13922> There are some whitespace chars. /trunk/KDE/kdenetwork/kopete/plugins/history2/history2dialog.cpp <http://svn.reviewboard.kde.org/r/6998/#comment13923> there too /trunk/KDE/kdenetwork/kopete/plugins/history2/history2guiclient.h <http://svn.reviewboard.kde.org/r/6998/#comment13924> same /trunk/KDE/kdenetwork/kopete/plugins/history2/history2guiclient.cpp <http://svn.reviewboard.kde.org/r/6998/#comment13925> here /trunk/KDE/kdenetwork/kopete/plugins/history2/history2guiclient.cpp <http://svn.reviewboard.kde.org/r/6998/#comment13926> here /trunk/KDE/kdenetwork/kopete/plugins/history2/history2import.h <http://svn.reviewboard.kde.org/r/6998/#comment13927> here (6x) /trunk/KDE/kdenetwork/kopete/plugins/history2/history2logger.h <http://svn.reviewboard.kde.org/r/6998/#comment13928> 2x - Pali Rohár On June 30, 2012, 5:32 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6998/ > ----------------------------------------------------------- > > (Updated June 30, 2012, 5:32 p.m.) > > > Review request for Kopete. > > > Description > ------- > > This is a copy of the old history plugin, but with so many changes, that I > created it as a new one "history2". > > Most important changes: > > - based on sqlite3 instead of xml-files > > - import history button in config dialog > > - import option added for the other xml-based history-plugin > > - pidgin import improved > > - test and skip duplicates on import (so it is possible to synchronize > regularly from a windows-pidgin installation for example) > > - more speed in most cases > > The main reason I began to rewrite the complete plugin was, that I had > dataloss by importing from pidgin with the old history plugin. > The months, which where imported from pidgin, did overwrite the kopete > history. This was unacceptable. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/plugins/CMakeLists.txt 1297320 > /trunk/KDE/kdenetwork/kopete/plugins/history2/CMakeLists.txt PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2chatui.rc > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2config.kcfg > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2config.kcfgc > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2dialog.h PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2dialog.cpp > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2guiclient.h > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2guiclient.cpp > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2import.h PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2import.cpp > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2logger.h PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2logger.cpp > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2plugin.h PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2plugin.cpp > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2preferences.h > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2preferences.cpp > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2prefsui.ui > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2ui.rc PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/history2viewer.ui > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/history2/kopete_history2.desktop > PRE-CREATION > > /trunk/KDE/kdenetwork/kopete/plugins/history2/kopete_history2_config.desktop > PRE-CREATION > > Diff: http://svn.reviewboard.kde.org/r/6998/diff/ > > > Testing > ------- > > I use it for several days now, and successfully imported my complete pidgin > and old kopete history (some megabytes since 2006). I think it is possible to > use both plugins parallel, although I would like to see this plugin to > replace the old one in longer term. On import nothing is deleted. > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
