On May 8, 2013, 4:12 p.m., Michael Palimaka wrote: > > V4L2_CID_BLACK_LEVEL and V4L2_CID_WHITENESS are marked as "deprecated", > > too, and will likely be removed soon. > > So while you are at it, please do the same for both, too (using separate > > #ifdefs).
Thanks, fixed the comment and added check for V4L2_CID_BLACK_LEVEL. I do not see any reference to V4L2_CID_WHITENESS in Kopete. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/7072/#review11053 ----------------------------------------------------------- On May 9, 2013, 1:18 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/7072/ > ----------------------------------------------------------- > > (Updated May 9, 2013, 1:18 p.m.) > > > Review request for Kopete. > > > Description > ------- > > With recent kernels, v4l support fails to build: > > /builddir/build/BUILD/kdenetwork-4.10.2/kopete/libkopete/avdevice/videodevice.cpp: > In member function 'const char* > Kopete::AV::VideoDevice::getUnifiedV4L2StdCtrlName(quint32)': > /builddir/build/BUILD/kdenetwork-4.10.2/kopete/libkopete/avdevice/videodevice.cpp:3064:8: > error: 'V4L2_CID_HCENTER' was not declared in this scope > case V4L2_CID_HCENTER: return I18N_NOOP("Horizontal Center"); > ^ > /builddir/build/BUILD/kdenetwork-4.10.2/kopete/libkopete/avdevice/videodevice.cpp:3065:8: > error: 'V4L2_CID_VCENTER' was not declared in this scope > case V4L2_CID_VCENTER: return I18N_NOOP("Vertical Center"); > ^ > > This patch by Kevin Kofler from Fedora > (https://bugzilla.redhat.com/show_bug.cgi?id=946924) solves the issue. > > > This addresses bug 319455. > https://bugs.kde.org/show_bug.cgi?id=319455 > > > Diffs > ----- > > /branches/KDE/4.10/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp > 1353128 > > Diff: http://svn.reviewboard.kde.org/r/7072/diff/ > > > Testing > ------- > > > Thanks, > > Michael Palimaka > >
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
