> On March 24, 2013, 2:15 a.m., Cyberbeat wrote: > > I tested with ICQ and it works as expected :-)
I see there one small problem. Kopete connecting to 3 ICQ servers (first redirect to second which redirect to third). And communication with second server is not encrypted (I tried to force SSL for it but failed). But maybe this is normal for all ICQ clients. Maybe we should add some info that not all connections are encrypted. Or maybe checking with wireshark can help what is not encrypted... - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/7069/#review11046 ----------------------------------------------------------- On March 23, 2013, 2:15 a.m., Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/7069/ > ----------------------------------------------------------- > > (Updated March 23, 2013, 2:15 a.m.) > > > Review request for Kopete. > > > Description > ------- > > This patch adding support for SSL to oscar protocol. I added only GUI > checkbox for ICQ accounts, because I do not have also AIM account for > testing. Maybe it will work with AIM and maybe not. > > > This addresses bug 198042. > https://bugs.kde.org/show_bug.cgi?id=198042 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimaccount.cpp 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqaccount.cpp 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/ui/icqeditaccountui.ui > 1345226 > > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/ui/icqeditaccountwidget.cpp > 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/client.h 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/client.cpp 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/connection.h 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/connection.cpp > 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/oscarclientstream.h > 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/oscarclientstream.cpp > 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/logintask.h > 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/logintask.cpp > 1345226 > > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/oscarlogintask.h > 1345226 > > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/oscarlogintask.cpp > 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tests/logintest.cpp > 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.h 1345226 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.cpp 1345226 > > Diff: http://svn.reviewboard.kde.org/r/7069/diff/ > > > Testing > ------- > > Tested with my ICQ account and working fine. > > > Thanks, > > Pali Rohár > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
