> On Nov. 11, 2012, 11:01 a.m., Cyberbeat wrote: > > if noone speaks against, then I'll commit this fix to trunk tomorrow
Hi, patch looks ok. Did you see any reported bug at bugzilla? - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6977/#review10991 ----------------------------------------------------------- On June 6, 2012, 4:35 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6977/ > ----------------------------------------------------------- > > (Updated June 6, 2012, 4:35 p.m.) > > > Review request for Kopete. > > > Description > ------- > > To reproduce the bug in nowlistening preferences kcm: > > - open the preferences for nowlistening plugin > - in the third tab check the checkbox and choose a mediaplayer > - close the dialog > - open preferences again (the checkbox is now already checked) > - choose another mediaplayer > - close the dialog > ==> the mediaplayer-selection is not applied > test that by opening the preferences again and look > > This patch replaces the k3listbox by a klistwidget, which solves the problem, > and seems a good idea anyway because k3listbox will be removed someday. > > > Diffs > ----- > > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp > 1298638 > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningprefs.ui > 1298638 > > Diff: http://svn.reviewboard.kde.org/r/6977/diff/ > > > Testing > ------- > > works for me > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
