On Monday 22 October 2012 14:31:25 Pali Rohár wrote: > On Sunday 07 October 2012 14:17:29 Lamarque V. Souza wrote: > > Em Wednesday 03 October 2012, Christoph Feck escreveu: > > > Hi Kopete developers, > > > > Hi, > > > > > since KDE 4.8.80 (KDE 4.9 alpha), we get multiple bug > > > reports > > > about Kopete crashing around > > > Kopete::MetaContact::isOnline(), see bug 301989 and newers > > > (links below) even when simply starting it. > > > > > > It looks like those are caused by the network status > > > updates > > > (commits r1283434, r1285546 ... r1289685) or the new > > > offline > > > group (commit r1282381). > > > > > > Could you have a look at the issue? > > > > Well, I am trying to figure out why it crashes but I have no > > > > clue yet. I am able to reproduce the crash and have a > > valgrind > > log (attached to https://bugs.kde.org/show_bug.cgi?id"9996) > > but I still do not see why it crashes. The crash seems older > > than all those commits above, maybe the commits make the > > problem more often, but I do not think they are the cause. > > Hello, I think that above commits did not intorduced this > crash. > > Kopete is crashing in function Kopete::MetaContact::isOnline. I > think it can happen only if Kopete::MetaContact object or > Kopete::Contact is deleted (pointer to *this is invalid). And > this can be in situation when you delete some metacontact > (move all subcontacts to other metacontact). Maybe quick & > dirty fix can be to use qt shared pointer to fix problem of > invalid pointer.
I created patch with using QPointer (instead C++ pointer), so Qt can handle deleting Kopete::MetaContact QObject and mark it as NULL. This fixed crashing Kopete on my computer and I'm not able to reproduce this bug again. Patch is here: https://bugs.kde.org/show_bug.cgi?id"9996#c10 Please test it and let me know if it really fixed this problem! -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
