> On Feb. 26, 2012, 11:52 a.m., Lamarque Souza wrote: > > trunk/extragear/network/kopete-cryptography/cryptographyplugin.h, line 89 > > <http://svn.reviewboard.kde.org/r/6768/diff/1/?file=46792#file46792line89> > > > > Do you know if this plugin really works with all those protocols? If so > > then this patch is good to go in my oppinion. > > Pali Rohár wrote: > This plugin send PGP signed/encrypted message via standard protocol. So > user who not using kopete with this plugin will get message like: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > test message > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > > iEYEARECAAYFAk9KHb4ACgkQi/DJPQPkQ1JVrwCdFrdjaM3YnY+bU+vPwVhT3NAP > HZMAoMbCNard1YocYfceOgU/sSOk+1Ng > =KvtM > -----END PGP SIGNATURE----- > > The only problem is if protocol support long messages. And all these > protocols should support long messages. Only problematic protocol is ICQ, > which is disabled.
Ok the. Patch pushed. Please close this review since svn is not doing it automatically. http://websvn.kde.org/?view=revision&revision=1282282 - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6768/#review10703 ----------------------------------------------------------- On Aug. 20, 2011, 8:59 a.m., Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6768/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2011, 8:59 a.m.) > > > Review request for Kopete. > > > Description > ------- > > This patch fix CMAKE_MODULE_PATH in CMakeLists.txt, update supported protocol > lists and update information box about unsupported protocol. > > > Diffs > ----- > > trunk/extragear/network/kopete-cryptography/CMakeLists.txt 1248234 > trunk/extragear/network/kopete-cryptography/cryptographyplugin.h 1248234 > trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp 1248234 > > Diff: http://svn.reviewboard.kde.org/r/6768/diff/ > > > Testing > ------- > > Patch working for me fine. > > > Thanks, > > Pali Rohár > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
