Em Saturday 25 February 2012, Pali Rohár escreveu: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5282/#review10699 > ----------------------------------------------------------- > > > Was this patch commited to trunk or not?
I has not been commited yet. I will commit it just to trunk. > - Pali Rohár > > On Sept. 9, 2010, 10:50 a.m., Igor Poboiko wrote: > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://svn.reviewboard.kde.org/r/5282/ > > ----------------------------------------------------------- > > > > (Updated Sept. 9, 2010, 10:50 a.m.) > > > > > > Review request for Kopete. > > > > > > Description > > ------- > > > > This patch adds notifications about status message in kopete chatwindow > > about contact's changed status message. It also fixes bug 160510 when > > status doesn't change, but kopete shows an notification about it. > > > > > > This addresses bugs 160510 and 193402. > > > > https://bugs.kde.org/show_bug.cgi?id=160510 > > https://bugs.kde.org/show_bug.cgi?id=193402 > > > > Diffs > > ----- > > > > /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.h 1172680 > > /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp 1172680 > > /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h 1172680 > > /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1172680 > > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1172680 > > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1172680 > > /trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimuserinfo.cpp > > 1172680 > > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqcontact.cpp > > 1172680 > > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icqcontactbase.cpp > > 1172680 /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.h > > 1172680 /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp > > 1172680 > > > > Diff: http://svn.reviewboard.kde.org/r/5282/diff/ > > > > > > Testing > > ------- > > > > Kopete from trunk compiles fine with it. It shows notifications for every > > user in chat (except the ones who haven't status messages). There is one > > problem: if user changes Xtraz status, it shows two notifications > > (because oscar protocol sends a message with status message, then kopete > > asks user about his status message and then sets it one more time - see > > attached screenshot). I don't know what to do with it. Suggestions are > > welcome. > > > > > > Screenshots > > ----------- > > > > Chat window (Hacker theme) > > > > http://svn.reviewboard.kde.org/r/5282/s/500/ > > > > Thanks, > > > > Igor Poboiko -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel