----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6544/ -----------------------------------------------------------
(Updated March 1, 2011, 9:31 p.m.) Review request for Kopete. Summary (updated) ------- In jabbercontact.cpp line 87: * Note: The only time account->myself() could be a * NULL pointer is if this contact here is the myself() * instance itself. Since in that case we wouldn't * get updates at all, we need to treat that as a * special case. So to check if this contact is the myself contact of an account, you would use if ( !account->myself() ) (Because when the myself contact is created it can't already be set as the myself contact of the account.) So I think that the comments in line 98 and 105 should be interchanged (as in diff r2). Can someone confirm this? Diffs ----- /branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1222695 Diff: http://svn.reviewboard.kde.org/r/6544/diff Testing ------- Thanks, alter_schwede
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
