----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6448/#review9837 -----------------------------------------------------------
Can you check if there are bug reports about this? - Raphael On Feb. 6, 2011, 6:50 p.m., Martin Blumenstingl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6448/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 6:50 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > This patch fixes a problem with kopete's "Last Seen" feature. > > See the following use-case: > -Contact::setOnlineStatus() sets the last seen date of a user > -if a user goes online the "last seen" property will be removed (and "online > since" will be added) > -if a user goes offline the "last seen" property is set (with the current > date/time) > -if your account goes offline then nothing is done for the account's contacts > > If user X was still online when account Y got disconnected the "Last Seen" > property was not written. > > The solution was quite trivial: > Once an account goes offline all of it's contacts have to be marked as > offline too. > > My patch should not change behavior in kopete. > Contact::setOnlineStatus() still does not emit onlineStatusChanged() as > account->isConnected() is false. > Notifications are also not shown, as Account::setAllContactsStatus() ensures > that notifications are disabled for 5 seconds. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccount.cpp 1219168 > > Diff: http://svn.reviewboard.kde.org/r/6448/diff > > > Testing > ------- > > -"Last Seen" is now written correctly > -"Online Since" is still shown correctly > > > Thanks, > > Martin > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
