----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6053/#review9437 -----------------------------------------------------------
Ship it! Haven't tested it, but the code looks OK. Does it close any bug report? /trunk/KDE/kdenetwork/kopete/plugins/history/historylogger.cpp <http://svn.reviewboard.kde.org/r/6053/#comment10442> Minor nitpick: maybe you should follow the other #includes' style and include module/header? - Raphael On 2010-12-05 16:23:03, Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6053/ > ----------------------------------------------------------- > > (Updated 2010-12-05 16:23:03) > > > Review request for Kopete. > > > Summary > ------- > > This patch add support for storing rich html messages in history. Before, all > messages was first converted to plaintext and then saved in history plugin. > Now html messages are saved in html format and are not converted to plaintext. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/plugins/history/historylogger.cpp 1203573 > > Diff: http://svn.reviewboard.kde.org/r/6053/diff > > > Testing > ------- > > Old history is loaded and displayed correctly. > Messages in plaintext with user writed html tags (If user write plaintext > message which contains < > & ... in chatwindow) are displayed correctly. > Messages in html with < & ... are displayed correctly too. > > > Thanks, > > Pali > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
