----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6085/#review9228 -----------------------------------------------------------
I see that you've committed your patch. Can you please close the request now? - Raphael On 2010-12-12 00:36:27, Pau Garcia i Quiles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6085/ > ----------------------------------------------------------- > > (Updated 2010-12-12 00:36:27) > > > Review request for Kopete and Olivier Goffart. > > > Summary > ------- > > Currently Kopete marks all Jabber contacts as able to receive files. > > It is possible to connect to the Facebook chat with Kopete via > chat.facebook.com, Facebook's Jabber server, which does NOT allow file > transfers. > > This patch does a very dirty check: if the Jabber contact is a Facebook > contact, mark it as file capable = false. > > Why is this important to me? Because by popular request I have implemented a > KIPI plugin for Kopete (extragear/graphics/kipi-plugins/kopete), which makes > possible to send files from Digikam, Gwenview, KSnapshot, etc to contacts > available in Kopete. Unless this patch is applied, Facebook contacts will be > shown in the list of contacts available to receive files (and of course the > file transfer will mysteriously fail when the user attempts to send a file). > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontactpool.cpp 1205649 > > Diff: http://svn.reviewboard.kde.org/r/6085/diff > > > Testing > ------- > > Works for me on Linux > > > Thanks, > > Pau > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
