----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5750/#review8468 -----------------------------------------------------------
Ship it! Looks OK to me. It might be good to hear from Frank Schaeffer first, though (I hope he's still around). In the future, it should be better to remove most of the OS checks and rely solely on ENABLE_AV being set correctly. - Raphael On 2010-11-01 22:07:53, Max Brazhnikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5750/ > ----------------------------------------------------------- > > (Updated 2010-11-01 22:07:53) > > > Review request for Kopete. > > > Summary > ------- > > Trivial patch to enable video support on FreeBSD via v4l compatibility. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.h 1192069 > trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp 1192069 > > Diff: http://svn.reviewboard.kde.org/r/5750/diff > > > Testing > ------- > > > Thanks, > > Max > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
