----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5346/#review7609 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp <http://svn.reviewboard.kde.org/r/5346/#comment7764> I do not think this is necessary because if d->tray is null slotTrayAboutToShowMenu will never be called. Take a look at KopeteWindow::initSystray, slotTrayAboutToShowMenu is connected to a signal only when d->tray is not null. - Lamarque On 2010-09-14 20:39:13, Nicolas Lécureuil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5346/ > ----------------------------------------------------------- > > (Updated 2010-09-14 20:39:13) > > > Review request for Kopete. > > > Summary > ------- > > i added a check for d->tray() as it can be null. This check already exist in > some functions like KopeteWindow::makeTrayToolTip() > > > This addresses bug 251226. > https://bugs.kde.org/show_bug.cgi?id=251226 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1175024 > > Diff: http://svn.reviewboard.kde.org/r/5346/diff > > > Testing > ------- > > > Thanks, > > Nicolas > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
