On Monday, April 19, 2010 11:33:04 am Teemu Rytilahti wrote: > > On 2010-04-17 18:12:22, Raphael Kubo da Costa wrote: > > > I don't know the code, so to an external reviewer the patch looks OK. > > > Do you have an SVN account? > > Yup, I do have an account, but of course it'd be nice if someone with > insight of the code could check this before I commit :-) > > > - Teemu > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3632/#review5087 > ----------------------------------------------------------- > > On 2010-04-17 14:53:56, Teemu Rytilahti wrote: > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.kde.org/r/3632/ > > ----------------------------------------------------------- > > > > (Updated 2010-04-17 14:53:56) > > > > > > Review request for Kopete. > > > > > > Summary > > ------- > > > > This patch uses KIO::encodeFilename() to encode the filename prior to > > saving it to the filesystem. This allows Kopete to save avatar photos > > for Jabber groupchat users (where JID has a slash; > > chatr...@server/userhandle). After this patch the avatar will be > > displayed in groupchat (though after its vCard is manually fetched > > first, another bug there). > > > > Earlier Kopete wasn't able to save the image as '/' is reserved character > > on *nix filesystems. > > > > > > This addresses bug 156184. > > > > https://bugs.kde.org/show_bug.cgi?id=156184 > > > > Diffs > > ----- > > > > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp 1115755 > > > > Diff: http://reviewboard.kde.org/r/3632/diff > > > > > > Testing > > ------- > > > > Tested with current Kopete trunk. > > 1) Join a XMPP chatroom > > 2) Open vcard dialog for a member of the chat and allow it to fetch the > > image 3) The avatar is now shown there. > > > > > > Thanks, > > > > Teemu
It does indeed look fine. Please commit -- Matt _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
