> On 2009-10-17 02:45:28, Matt Rogers wrote: > > what does clearsign mode do exactly and why should we enable it by default? > > > > In theory, the patch looks fine, but I'm not sure I agree with the change > > in defaults.
After added option in configuration dialog for this plugin (patch rev. 2), is there any other problem? When user send signed message in clearsign mode, message is readable in all clients (without gpg support). But when user send normal signed message, this message can user read only in IM client with GPG support. - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1657/#review2678 ----------------------------------------------------------- On 2009-10-17 16:14:07, Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1657/ > ----------------------------------------------------------- > > (Updated 2009-10-17 16:14:07) > > > Review request for Kopete. > > > Summary > ------- > > This patch add support to verify signed messages in clearsign mode and setup > clearsign mode as default instead normal mode. > > If message is signed in normal mode, user who doesnt have gnugpg, he cant > read this message. But message in clearsign mode is readable without gpg. > > > Diffs > ----- > > /trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp 1036355 > /trunk/extragear/network/kopete-cryptography/cryptographypreferences.h > 1036355 > /trunk/extragear/network/kopete-cryptography/cryptographypreferences.cpp > 1036355 > /trunk/extragear/network/kopete-cryptography/cryptographysettings.kcfg > 1036355 > > Diff: http://reviewboard.kde.org/r/1657/diff > > > Testing > ------- > > It works fine. > > Kopete now check signed messages in normal or clearsign mode and encrypted > messages. > > > Thanks, > > Pali > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
