----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3063/#review4285 -----------------------------------------------------------
Ship it! looks fine, if you can test on multiple protocols with no side effects, please commit. - Matt On 2010-02-26 17:08:45, Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3063/ > ----------------------------------------------------------- > > (Updated 2010-02-26 17:08:45) > > > Review request for Kopete. > > > Summary > ------- > > If user change display name of metacontact, not always is funcion > Kopete::Contact::sync(Kopete::Contact::DisplayNameChanged) called. (Without > this patch only when user change custom display name in metacontact > configuration widget). > > This patch calling function sync() always when display name is changed. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1096330 > > Diff: http://reviewboard.kde.org/r/3063/diff > > > Testing > ------- > > I tested it with ICQ patch too and for me works fine. > Before when I changed display name from custom to KABC, function sync was not > called and contact name on server side not changed. > > > Thanks, > > Pali > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
