----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2558/ -----------------------------------------------------------
(Updated 2010-01-12 22:20:56.595437) Review request for Kopete. Changes ------- added two more fixes - fix loading of video-setting "mirror image" - do not save device automatically when open is called with an explicit device number Summary ------- This Patch fixes loading/saving of the video-settings: - split loading into loading of the selected video-device and loading of the device-settings - load selected device BEFORE opening the video-device - fix nr of clients (m_clients) in videodevicepool after device-removing - fix nr of clients (m_clients) in videodevicepool when device-open fails - remove device model from model-pool after device-removing It is intended for 4.4-branch only, I will send patches for trunk later. Please note that there are still problems when multiple identical devices are in use ! Diffs (updated) ----- /trunk/KDE/kdenetwork/kopete/kopete/config/avdevice/avdeviceconfig.cpp 1073783 /trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevicemodelpool.h 1073783 /trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevicemodelpool.cpp 1073783 /trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevicepool.h 1073783 /trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevicepool.cpp 1073783 /trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videoinput.cpp 1073783 /trunk/KDE/kdenetwork/kopete/libkopete/ui/avatarwebcamdialog.cpp 1073783 Diff: http://reviewboard.kde.org/r/2558/diff Testing ------- Thoroughly tested. Thanks, Frank _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
