On Sunday 27 December 2009 07:51:09 pm Alex Merry wrote: > When trying to generate an avatar from a webcam capture, kopete crashed. I > fixed the crash and committed it (just a guard on the size of the > destination of memcpy - r1066810 [trunk], r1066826 [4.3]), but the > underlying problem was still there, causing the image from the webcam to > be screwed up. > > The problem is that the configure dialog's A/V page webcam widget sets the > webcam capture size to 320x240, then the avatar webcam dialog tries to set > it to 640x480. This fails (because the device is in use), but the > VideoDevice class goes ahead assuming it worked. > > The attached patch is a quick fix for it. It also fixes the problem where > you can get a camera listed multiple times in the A/V config page. > > The fix is pretty straightforward and minimal - I'd like to tidy up the > webcam support in kopete properly when we're out of feature freeze. > > Alex
looks fine. please commit. -- Matt
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel