On Friday 04 September 2009 09:30:26 am Pali Rohár wrote: > I fix using smbclient. I add param -I <ip_address> because some smbclient > doesnt work without param -I. Sometime smbclient doesnt get workgroup for > localhost. Winpopup protocol is then offline but no error show. I add > default localhost workgroup WORKGROUP, so it fix. I think it is BUG > 140142. > > This patch also fix show myself name in chat window and Comment in user > info dialog. > > Can I commit it to svn? > > I cannot upload this patch to reviewboard (same error). > > > Hello, > > I ported from kopete-kde3 button "Install into Samba" for initialize this > > protocol in samba. This button exist near host name in account widget, > > but it has none name and do nothing. After click it use bash script > > winpopup-install. > > > > And also I fix sending messages and script winpopup-install. > > I remove suffix .sh from scripts winpopup-install and winpopup-send > > because it use bash (not sh). > > > > I try upload this patch to reviewboard, but it show me error: > > The file > > '/trunk/KDE/kdenetwork/kopete/protocols/winpopup/winpopup-install' > > (r1007087) could not be found in the repository > > > > I never seen this error before. Patch I generate with svn diff. >
Looks fine to me. Please commit. -- Matt
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel