----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1153/#review1858 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp <http://reviewboard.kde.org/r/1153/#comment1217> Maybe the action creation and the signal connection should all be put inside the #ifdef? I mean, the action is not useful at all if voiceclip sending is not enabled, so there is no point in keep it, right? /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp <http://reviewboard.kde.org/r/1153/#comment1218> I would just suggest adding some comments in the function body (as it is not a small function, comments make it easier to identify what part of the code does what) - Gustavo On 2009-07-28 21:42:44, Tiago Salem Herrmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1153/ > ----------------------------------------------------------- > > (Updated 2009-07-28 21:42:44) > > > Review request for Kopete. > > > Summary > ------- > > This patch will create a button in the chat window to send voice clips to > other contacts. > The support will be optional and to get it enabled the user must have > libmsn-4.0-beta7 and mediastreamer2 library, provided by linphone package. > It can be easily ported to use phonon when the capture feature is fully > implemented. > In addition to this patch, I'll ask in the kde usability list about what is > the better way to implement that (visual design), but for now I would like to > get it first reviewed and committed the way as is. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/CMakeLists.txt 999832 > /trunk/KDE/kdenetwork/kopete/cmake/modules/FindMediastreamer.cmake > PRE-CREATION > /trunk/KDE/kdenetwork/kopete/protocols/wlm/CMakeLists.txt 1001377 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.h 999832 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp 999832 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatui.rc 999832 > > Diff: http://reviewboard.kde.org/r/1153/diff > > > Testing > ------- > > Voice clips were sent to the official and 3rd party clients, and everything > seems to be ok. > > > Thanks, > > Tiago > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
