Shouldn't just the ink support be compiled instead of the whole WLM? On Tue, Jun 30, 2009 at 4:16 AM, Matt Rogers <ma...@kde.org> wrote:
> > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/909/#review1417 > ----------------------------------------------------------- > > Ship it! > > > Looks fine to me. Please commit. > > > /trunk/KDE/kdenetwork/kopete/CMakeLists.txt > <http://reviewboard.kde.org/r/909/#comment882> > > it doesn't look like CheckStructMember is used anywhere here and should > be removed. > > > - Matt > > > On 2009-06-29 18:02:09, Tiago Salem Herrmann wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.kde.org/r/909/ > > ----------------------------------------------------------- > > > > (Updated 2009-06-29 18:02:09) > > > > > > Review request for Kopete. > > > > > > Summary > > ------- > > > > In order to have the "ink writing" support, wlm needs to link against > libgif/libungif. > > This patch makes cmake compile wlm only if libgif is installed. > > > > The full ink support code will be committed with this patch. > > > > > > Diffs > > ----- > > > > /trunk/KDE/kdenetwork/kopete/CMakeLists.txt 989188 > > /trunk/KDE/kdenetwork/kopete/protocols/CMakeLists.txt 989188 > > > > Diff: http://reviewboard.kde.org/r/909/diff > > > > > > Testing > > ------- > > > > The libgif (devel) was removed from the system and the wlm plugin was not > built. > > > > > > Thanks, > > > > Tiago > > > > > > _______________________________________________ > kopete-devel mailing list > kopete-devel@kde.org > https://mail.kde.org/mailman/listinfo/kopete-devel >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
