----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/768/#review1219 -----------------------------------------------------------
Hi, you somehow added wrong path for the diff so the diff isn't shown. Here's the review: The QString txt = text( Qt::PlainText ); in slotTextChanged is redundant. I think it would be better to fix it in KopeteRichTextWidget::event. I suggest to add keyEvent->key() == Qt::Key_Return || keyEvent->key() == Qt::Key_Enter also for Press or Release event (depends on which on we should override). The best thing would be to get action keysequence for "chat_send" from d->actionCollection and cache it and then use it in KopeteRichTextWidget::event - Roman On 2009-05-26 12:56:52, Welsh_Dwarf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/768/ > ----------------------------------------------------------- > > (Updated 2009-05-26 12:56:52) > > > Review request for Kopete. > > > Summary > ------- > > This patch fixes bug 91409: an empty line is sometimes inserted at the start > of a message if the type holds down the enter key for too long. > > > This addresses bug 91409. > https://bugs.kde.org/show_bug.cgi?id=91409 > > > Diffs > ----- > > kdenetwork/kopete/kopete/chatwindow/chattexteditpart.cpp 973260 > > Diff: http://reviewboard.kde.org/r/768/diff > > > Testing > ------- > > I've sent test messages using a patched kopete and held down, and repeatedly > pressed the enter key to insure that it is no longer possible to insert a > blank line at the start of a message. This fixes the bug. > > A possible complication would be if the user re-configured send to another > key and tried to insert a blank line at the start of the message (to do some > ascii art or something like that). If such a case arrose, the user would have > to put another caracter in fromt (a space or some introductory text) in order > to be able to use new lines. > > > Thanks, > > Welsh_Dwarf > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
