Your version isn't wrong also... See the last paragraph at http://en.wikipedia.org/wiki/Enter_key :)) So it's application specific. But since the de facto standard exists that all IMs (that I've used) use Return and Enter for sending and Ctrl+Return (or Enter) for starting new line, we should also implement this in such a way.
Roman 2009/3/17 Jaroslav Reznik <[email protected]>: > On Tuesday 17 March 2009 15:44:18 Roman Byshko wrote: >> 2009/3/17 Jaroslav Reznik <[email protected]>: >> > On Tuesday 17 March 2009 14:46:35 Roman Byshko wrote: >> >> Well, if you want such a feature one can start new line with Ctrl + >> >> Enter. In this way it's done in all IMs I've seen. Definition of >> >> different actions for the same keys on the keyboard that bassically >> >> represent one key is not a good idea, I think. At least this can lead >> >> to misunderstanding. And as I've allready said all the others use Ctrl >> >> + Enter. >> > >> > The question is why is it done this way in Qt - Return is Enter on main >> > keyboard, Enter is on numpad. >> >> I think the answer is simple. It's done to give a developer full >> controll over the keyboard for those case if you do want to know which >> Enter was pushed. >> >> > I'm thinking about it in Makneto (shared board IM) too, currently I've >> > implemented it as you wrote - "big" enter sends message, ctrl+enter & >> > numpad enter new line. It's default behavior for Qt apps (not the >> > ctrl+enter combination, I have it only for compatibility with other IM). >> > So we should comply with Qt's defaults. >> >> I've read documentation of Qt before sending this patch. But haven't >> managed to find any recomendations for using 'Enter' and 'Return' in >> this way. So I dont undestand why do you think it's default behaviour? >> For which Qt apps is it default? > > You are right - even sending on return is not default behavior of Qt. It's > only my subjective feeling I'm used to use from Kopete. Sorry. > > Jaroslav > >> Roman. >> >> > Jaroslav >> > >> >> Roman. >> >> >> >> 2009/3/17 Jaroslav Reznik <[email protected]>: >> >> > On Tuesday 17 March 2009 14:29:00 Guillaume Pothier wrote: >> >> >> Arf, I thought it was a feature: let's you do multiline messages >> >> >> (poetry, etc.) Cheers, >> >> >> g >> >> > >> >> > Indeed, I think it's a feature not a bug :) >> >> > >> >> > Jaroslav >> >> > >> >> >> On Mon, Mar 16, 2009 at 2:58 PM, Matt Rogers <[email protected]> wrote: >> >> >> > ----------------------------------------------------------- >> >> >> > This is an automatically generated e-mail. To reply, visit: >> >> >> > http://reviewboard.kde.org/r/335/#review499 >> >> >> > ----------------------------------------------------------- >> >> >> > >> >> >> > Ship it! >> >> >> > >> >> >> > >> >> >> > Looks fine. does this need to be committed on your behalf? >> >> >> > >> >> >> > - Matt >> >> >> > >> >> >> > On 2009-03-16 06:34:47, Roman Spielerman wrote: >> >> >> >> ----------------------------------------------------------- >> >> >> >> This is an automatically generated e-mail. To reply, visit: >> >> >> >> http://reviewboard.kde.org/r/335/ >> >> >> >> ----------------------------------------------------------- >> >> >> >> >> >> >> >> (Updated 2009-03-16 06:34:47) >> >> >> >> >> >> >> >> >> >> >> >> Review request for Kopete. >> >> >> >> >> >> >> >> >> >> >> >> Summary >> >> >> >> ------- >> >> >> >> >> >> >> >> When hitting on the Enter which is located on the touchpad Kopete >> >> >> >> does not send a message but starts new line. Here the patch to >> >> >> >> make Kopete send messages either on Enter and Numpad-Enter. >> >> >> >> >> >> >> >> >> >> >> >> Diffs >> >> >> >> ----- >> >> >> >> >> >> >> >> >> >> >> >> /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cp >> >> >> >>p 939700 >> >> >> >> >> >> >> >> Diff: http://reviewboard.kde.org/r/335/diff >> >> >> >> >> >> >> >> >> >> >> >> Testing >> >> >> >> ------- >> >> >> >> >> >> >> >> >> >> >> >> Thanks, >> >> >> >> >> >> >> >> Roman >> >> >> > >> >> >> > _______________________________________________ >> >> >> > kopete-devel mailing list >> >> >> > [email protected] >> >> >> > https://mail.kde.org/mailman/listinfo/kopete-devel >> >> >> >> >> >> _______________________________________________ >> >> >> kopete-devel mailing list >> >> >> [email protected] >> >> >> https://mail.kde.org/mailman/listinfo/kopete-devel >> >> > >> >> > -- >> >> > Jaroslav Řezník <[email protected]> >> >> > Associate Software Engineer - Base Operating Systems Brno >> >> > >> >> > Office: +420 532 294 275 >> >> > Mobile: +420 731 455 332 >> >> > Red Hat, Inc. http://cz.redhat.com/ >> >> > _______________________________________________ >> >> > kopete-devel mailing list >> >> > [email protected] >> >> > https://mail.kde.org/mailman/listinfo/kopete-devel >> >> >> >> _______________________________________________ >> >> kopete-devel mailing list >> >> [email protected] >> >> https://mail.kde.org/mailman/listinfo/kopete-devel >> > >> > -- >> > Jaroslav Řezník <[email protected]> >> > Associate Software Engineer - Base Operating Systems Brno >> > >> > Office: +420 532 294 275 >> > Mobile: +420 731 455 332 >> > Red Hat, Inc. http://cz.redhat.com/ >> > _______________________________________________ >> > kopete-devel mailing list >> > [email protected] >> > https://mail.kde.org/mailman/listinfo/kopete-devel >> >> _______________________________________________ >> kopete-devel mailing list >> [email protected] >> https://mail.kde.org/mailman/listinfo/kopete-devel > > -- > Jaroslav Řezník <[email protected]> > Associate Software Engineer - Base Operating Systems Brno > > Office: +420 532 294 275 > Mobile: +420 731 455 332 > Red Hat, Inc. http://cz.redhat.com/ > _______________________________________________ > kopete-devel mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/kopete-devel > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
