Matt Rogers wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/322/#review491
> -----------------------------------------------------------
>
> Ship it!
>
>
> looks fine to me. please commit and mark as submitted after the commit.
>
> You should also backport this one, along with your other patch wrt the code 
> duplication.
>
> - Matt
>
>
> On 2009-03-15 07:42:09, Benson Tsai wrote:
>   
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/322/
>> -----------------------------------------------------------
>>
>> (Updated 2009-03-15 07:42:09)
>>
>>
>> Review request for Kopete.
>>
>>
>> Summary
>> -------
>>
>> Currently the WLM plugin does not display the message until it receives 
>> acknowledgment that the message got through. This patch changes the behavior 
>> so it displays the message immediately but uses the message sending state to 
>> indicate whether or not the message has gone through.
>>
>>
>> Diffs
>> -----
>>
>>   /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp 937810 
>>
>> Diff: http://reviewboard.kde.org/r/322/diff
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Benson
>>     
Sometimes the message is not delivered, so I think we should provide a 
queue and a timer for each message, so then we can track when a message 
could not be delivered properly. I personally like to see the status 
icon blinking while the message is not sent.
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to