----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/160/#review293 -----------------------------------------------------------
Ship it! go ahead and commit. thanks. - Matt On 2009-02-22 14:42:17, Roman Jarosz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/160/ > ----------------------------------------------------------- > > (Updated 2009-02-22 14:42:17) > > > Review request for Kopete and Roman Jarosz. > > > Summary > ------- > > This patch implements contact list layout for model/view branch, most code is > taken from Amarok. The patch is almost ready I just need to polish the > configuration dialog (emit changed signal and add create/delete layout > buttons) for this I want to wait for improved configuration dialog which > should be merged into Amarok this week. > > The classes in kopete/config/appearance/layout directory are copied from > Amarok and weren't changed. > So for now you can ignore the kopete/config/appearance/ changes, the rest > should be more or less ready for review. > > > Diffs > ----- > > /branches/work/kopete/dev-4.2/kopete/CMakeLists.txt 929355 > /branches/work/kopete/dev-4.2/kopete/config/appearance/CMakeLists.txt > 929355 > /branches/work/kopete/dev-4.2/kopete/config/appearance/appearanceconfig.cpp > 929355 > > /branches/work/kopete/dev-4.2/kopete/config/appearance/contactlistlayoutitemwidget.h > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/contactlistlayoutitemwidget.cpp > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/contactlistlayoutwidget.h > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/contactlistlayoutwidget.cpp > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/contactlistlayoutwidget.ui > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/layout/FilenameLayoutWidget.h > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/layout/FilenameLayoutWidget.cpp > PRE-CREATION > /branches/work/kopete/dev-4.2/kopete/config/appearance/layout/Token.h > PRE-CREATION > /branches/work/kopete/dev-4.2/kopete/config/appearance/layout/Token.cpp > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/layout/TokenListWidget.h > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/layout/TokenListWidget.cpp > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/layout/TokenWithLayout.h > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/config/appearance/layout/TokenWithLayout.cpp > PRE-CREATION > /branches/work/kopete/dev-4.2/kopete/contactlist/CMakeLists.txt > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/contactlist/DefaultContactListLayouts.xml > PRE-CREATION > /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistlayoutmanager.h > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistlayoutmanager.cpp > PRE-CREATION > /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistmodel.h 929355 > /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistmodel.cpp > 929355 > > /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistprettyitemconfig.h > PRE-CREATION > > /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistprettyitemconfig.cpp > PRE-CREATION > /branches/work/kopete/dev-4.2/kopete/contactlist/contactlistproxymodel.h > 929355 > /branches/work/kopete/dev-4.2/kopete/contactlist/kabcexport.h 929355 > /branches/work/kopete/dev-4.2/kopete/contactlist/kopetecontactlistview.h > 929355 > /branches/work/kopete/dev-4.2/kopete/contactlist/kopetecontactlistview.cpp > 929355 > /branches/work/kopete/dev-4.2/kopete/contactlist/kopeteitembase.h 929355 > /branches/work/kopete/dev-4.2/kopete/contactlist/kopeteitemdelegate.h > 929355 > /branches/work/kopete/dev-4.2/kopete/contactlist/kopeteitemdelegate.cpp > 929355 > /branches/work/kopete/dev-4.2/libkopete/kopete_export.h 929355 > /branches/work/kopete/dev-4.2/libkopete/kopetemetacontact.h 929355 > /branches/work/kopete/dev-4.2/libkopete/kopetemetacontact.cpp 929355 > /branches/work/kopete/dev-4.2/libkopete/kopetemetacontact_p.h 929355 > > Diff: http://reviewboard.kde.org/r/160/diff > > > Testing > ------- > > > Screenshots > ----------- > > Contact list layout and configuration dialog > http://reviewboard.kde.org/r/160/s/28/ > > > Thanks, > > Roman > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
