-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/142/
-----------------------------------------------------------
(Updated 2009-02-21 01:14:16.148991)
Review request for Kopete, Matt Rogers and gja.
Changes
-------
Lots of things moving about. CMakeLists.txt hacked. CMake Modules moved. Good
fun all around.
Summary
-------
Well, this is more of a patch for developers. It sets the directory which is
used for includes as /kdenetwork/kopete ratherthan /kdenetwork. This has no
effects to users or even packagers. My use case is that I have a
/src/kdenetwork/kopete (From trunk) and a /src/branch/kopete-dev-4.2.
Kopete can now be built outside of kdenetwork just by adding the following
lines to Kopete's main CMakeLists.txt (all of these lines may not be needed):
find_package(KDE4 REQUIRED)
include (KDE4Defaults)
include (MacroLibrary)
include(CheckIncludeFile)
include(CheckIncludeFiles)
include(CheckSymbolExists)
include(CheckFunctionExists)
include(CheckLibraryExists)
include(CheckPrototypeExists)
include(CheckTypeSize)
include(MacroBoolTo01)
include(MacroOptionalAddSubdirectory)
find_package(KdepimLibs REQUIRED)
add_definitions (${QT_DEFINITIONS} ${KDE4_DEFINITIONS})
include_directories (${KDE4_INCLUDES} ${KDEPIMLIBS_INCLUDE_DIR})
Of course, this is only useful if you plan on having multiple trees of kopete
on your system which share a single environment. This way, I can have multiple
trees of kopete, and need not worry about a separate kdenetwork tree for each
of them. Yay!
Respond on kopete mailing list if i can commit this
Diffs (updated)
-----
/dev/null 928222
/dev/null 928222
/dev/null 928222
/dev/null 928222
/dev/null 928222
/dev/null 928222
/dev/null 928222
/dev/null 928222
/dev/null 928222
/trunk/KDE/kdenetwork/CMakeLists.txt 928222
/trunk/KDE/kdenetwork/cmake/modules/FindDecibel.cmake 928222
/trunk/KDE/kdenetwork/cmake/modules/FindIDN.cmake 928222
/trunk/KDE/kdenetwork/cmake/modules/FindLibMeanwhile.cmake 928222
/trunk/KDE/kdenetwork/cmake/modules/FindLibOTR.cmake 928222
/trunk/KDE/kdenetwork/cmake/modules/FindLibgadu.cmake 928222
/trunk/KDE/kdenetwork/cmake/modules/FindLibmsn.cmake 928222
/trunk/KDE/kdenetwork/cmake/modules/FindLiboRTP.cmake 928222
/trunk/KDE/kdenetwork/cmake/modules/FindSpeex.cmake 928222
/trunk/KDE/kdenetwork/cmake/modules/ortpversion.c 928222
/trunk/KDE/kdenetwork/kopete/CMakeLists.txt 928222
/trunk/KDE/kdenetwork/kopete/kopete/CMakeLists.txt 928222
/trunk/KDE/kdenetwork/kopete/kopete/config/accounts/CMakeLists.txt 928222
/trunk/KDE/kdenetwork/kopete/kopete/config/chatwindow/CMakeLists.txt 928222
/trunk/KDE/kdenetwork/kopete/kopete/identity/CMakeLists.txt 928222
/trunk/KDE/kdenetwork/kopete/protocols/CMakeLists.txt 928222
/trunk/KDE/kdenetwork/kopete/protocols/groupwise/CMakeLists.txt 928222
/trunk/KDE/kdenetwork/kopete/protocols/groupwise/libgroupwise/CMakeLists.txt
928222
/trunk/KDE/kdenetwork/kopete/protocols/groupwise/libgroupwise/tasks/tests/CMakeLists.txt
928222
/trunk/KDE/kdenetwork/kopete/protocols/groupwise/libgroupwise/tests/CMakeLists.txt
928222
/trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tests/CMakeLists.txt
928222
/trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/tests/CMakeLists.txt
928222
Diff: http://reviewboard.kde.org/r/142/diff
Testing
-------
It builds here :)
I set KOPETE_FOO_DIR to ${CMAKE_CURRENT_FOO_DIR} in the beginning, which is
guaranteed to work unless CMake Borks someday in the future.
All paths are relative.
Thanks,
gja
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel
